Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: fpdfsdk/javascript/Document.cpp

Issue 1801383002: Re-enable several MSVC warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« fpdfsdk/fxedit/fxet_ap.cpp ('K') | « fpdfsdk/fxedit/fxet_ap.cpp ('k') | pdfium.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/javascript/Document.cpp
diff --git a/fpdfsdk/javascript/Document.cpp b/fpdfsdk/javascript/Document.cpp
index 5f6291b35a5e1df29fb69c71593ace42964358ae..2e387efa151e2529dc9b945fab9cdf1ede18db00 100644
--- a/fpdfsdk/javascript/Document.cpp
+++ b/fpdfsdk/javascript/Document.cpp
@@ -1459,7 +1459,7 @@ int Document::CountWords(CPDF_TextObject* pTextObj) {
FX_BOOL bIsLatin = FALSE;
for (int i = 0, sz = pTextObj->CountChars(); i < sz; i++) {
- FX_DWORD charcode = -1;
+ FX_DWORD charcode = static_cast<FX_DWORD>(-1);
dsinclair 2016/03/16 13:23:32 ditto
Wei Li 2016/03/16 17:51:32 Done.
Tom Sepez 2016/03/16 18:35:00 meh.
Wei Li 2016/03/17 02:24:06 Ditto
FX_FLOAT kerning;
pTextObj->GetCharInfo(i, charcode, kerning);
@@ -1492,7 +1492,7 @@ CFX_WideString Document::GetObjWordStr(CPDF_TextObject* pTextObj,
FX_BOOL bIsLatin = FALSE;
for (int i = 0, sz = pTextObj->CountChars(); i < sz; i++) {
- FX_DWORD charcode = -1;
+ FX_DWORD charcode = static_cast<FX_DWORD>(-1);
dsinclair 2016/03/16 13:23:32 ditto
Wei Li 2016/03/16 17:51:31 Done.
FX_FLOAT kerning;
pTextObj->GetCharInfo(i, charcode, kerning);
« fpdfsdk/fxedit/fxet_ap.cpp ('K') | « fpdfsdk/fxedit/fxet_ap.cpp ('k') | pdfium.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698