Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: fpdfsdk/fxedit/fxet_ap.cpp

Issue 1801383002: Re-enable several MSVC warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« fpdfsdk/fpdfview.cpp ('K') | « fpdfsdk/fpdfview.cpp ('k') | fpdfsdk/javascript/Document.cpp » ('j') | fpdfsdk/javascript/Document.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/fxedit/fxet_ap.cpp
diff --git a/fpdfsdk/fxedit/fxet_ap.cpp b/fpdfsdk/fxedit/fxet_ap.cpp
index 6f064b2ce89e19d7ed0bce68930293bc7994c866..9e235673e84b08ed58eac8ed43fd1ff9aa9560af 100644
--- a/fpdfsdk/fxedit/fxet_ap.cpp
+++ b/fpdfsdk/fxedit/fxet_ap.cpp
@@ -18,7 +18,7 @@ CFX_ByteString GetPDFWordString(IFX_Edit_FontMap* pFontMap,
if (SubWord > 0) {
Word = SubWord;
} else {
- FX_DWORD dwCharCode = -1;
+ FX_DWORD dwCharCode = 0;
Tom Sepez 2016/03/16 18:35:00 Init shouldn't be required given lines 23-26
Wei Li 2016/03/17 02:24:06 Acknowledged.
Tom Sepez 2016/03/16 18:35:00 nit: no blank line here.
Wei Li 2016/03/17 02:24:06 Acknowledged.
if (pPDFFont->IsUnicodeCompatible())
dwCharCode = pPDFFont->CharCodeFromUnicode(Word);
« fpdfsdk/fpdfview.cpp ('K') | « fpdfsdk/fpdfview.cpp ('k') | fpdfsdk/javascript/Document.cpp » ('j') | fpdfsdk/javascript/Document.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698