Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1801223002: Add gnu.build.id to shared libraries in GN. (Closed)

Created:
4 years, 9 months ago by Torne
Modified:
4 years, 9 months ago
Reviewers:
agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Add gnu.build.id to shared libraries in GN. We were doing this in gyp builds but not GN; add this in the GN config too so that we can be sure crash symbols match. BUG=594975 R=agrieve@chromium.org Review URL: https://codereview.chromium.org/1801073002 . Cr-Commit-Position: refs/heads/master@{#381242} (cherry picked from commit e67cbae553e592e7683aefc74c775f1e4a99296a) Committed: https://chromium.googlesource.com/chromium/src/+/d4c1f36bc7c8ec64fbc0507176fc3ce51adf38d1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/config/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Torne
4 years, 9 months ago (2016-03-15 18:27:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d4c1f36bc7c8ec64fbc0507176fc3ce51adf38d1.

Powered by Google App Engine
This is Rietveld 408576698