Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1801073002: Add gnu.build.id to shared libraries in GN. (Closed)

Created:
4 years, 9 months ago by Torne
Modified:
4 years, 9 months ago
Reviewers:
agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add gnu.build.id to shared libraries in GN. We were doing this in gyp builds but not GN; add this in the GN config too so that we can be sure crash symbols match. BUG=594975 R=agrieve@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/e67cbae553e592e7683aefc74c775f1e4a99296a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/config/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Torne
4 years, 9 months ago (2016-03-15 14:37:08 UTC) #2
agrieve
On 2016/03/15 14:37:08, Torne wrote: Yikes! I even knew about this, but thought it was ...
4 years, 9 months ago (2016-03-15 14:40:14 UTC) #3
agrieve
On 2016/03/15 14:40:14, agrieve wrote: > On 2016/03/15 14:37:08, Torne wrote: > > Yikes! I ...
4 years, 9 months ago (2016-03-15 14:40:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801073002/1
4 years, 9 months ago (2016-03-15 14:40:41 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/117620)
4 years, 9 months ago (2016-03-15 17:00:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801073002/1
4 years, 9 months ago (2016-03-15 17:04:31 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e67cbae553e592e7683aefc74c775f1e4a99296a Cr-Commit-Position: refs/heads/master@{#381242}
4 years, 9 months ago (2016-03-15 17:39:24 UTC) #12
Torne
4 years, 9 months ago (2016-03-15 17:40:14 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e67cbae553e592e7683aefc74c775f1e4a99296a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698