Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4092)

Unified Diff: build/config/ios/rules.gni

Issue 1801083002: [iOS] Add assert_no_deps to //build/config/ios/rules.gni "app" template. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@components-invalidation
Patch Set: Forbid dependency on third_party/webrtc Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/ios/rules.gni
diff --git a/build/config/ios/rules.gni b/build/config/ios/rules.gni
index 5bf2bd7cd489357144fb94994b29b941368d595a..850559d4588243702bf53c96a0cb219844a309c1 100644
--- a/build/config/ios/rules.gni
+++ b/build/config/ios/rules.gni
@@ -111,6 +111,26 @@ template("app") {
libs = []
}
libs += [ "UIKit.framework" ]
+
+ if (is_ios) {
+ assert_no_deps = [
brettw 2016/03/15 18:04:17 I think we should forward this from the invoker to
+ # Those dependencies are conceptually bad on iOS and should never be
+ # added (they will never be supported).
+ "//cc/*",
+ "//content/*",
+ "//dbus/*",
+ "//ipc/*",
+ "//jingle/*",
+ "//media/*",
+ "//third_party/webrtc/*",
+ "//third_party/WebKit/*",
+
+ # Those dependencies are conceptually fine, but currently does not
+ # build on iOS. The exclusion will be removed when the dependencies
+ # are fixed.
+ "//mojo/edk/*",
+ ]
+ }
}
bundle_data(_bundle_data_executable) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698