Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: build/config/ios/rules.gni

Issue 1801083002: [iOS] Add assert_no_deps to //build/config/ios/rules.gni "app" template. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@components-invalidation
Patch Set: Forbid dependency on third_party/webrtc Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/ios/ios_sdk.gni") 5 import("//build/config/ios/ios_sdk.gni")
6 6
7 # TODO(crbug.com/297668): refactor this template to extract common behaviour 7 # TODO(crbug.com/297668): refactor this template to extract common behaviour
8 # between OS X and iOS bundle generation, then create a generic "app" template 8 # between OS X and iOS bundle generation, then create a generic "app" template
9 # that forward to "executable" on all platform except iOS/OS X. 9 # that forward to "executable" on all platform except iOS/OS X.
10 10
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 "entitlements_path", 104 "entitlements_path",
105 "info_plist", 105 "info_plist",
106 "visibility", 106 "visibility",
107 ]) 107 ])
108 108
109 output_name = rebase_path("$target_gen_dir/$_app_name", root_build_dir) 109 output_name = rebase_path("$target_gen_dir/$_app_name", root_build_dir)
110 if (!defined(libs)) { 110 if (!defined(libs)) {
111 libs = [] 111 libs = []
112 } 112 }
113 libs += [ "UIKit.framework" ] 113 libs += [ "UIKit.framework" ]
114
115 if (is_ios) {
116 assert_no_deps = [
brettw 2016/03/15 18:04:17 I think we should forward this from the invoker to
117 # Those dependencies are conceptually bad on iOS and should never be
118 # added (they will never be supported).
119 "//cc/*",
120 "//content/*",
121 "//dbus/*",
122 "//ipc/*",
123 "//jingle/*",
124 "//media/*",
125 "//third_party/webrtc/*",
126 "//third_party/WebKit/*",
127
128 # Those dependencies are conceptually fine, but currently does not
129 # build on iOS. The exclusion will be removed when the dependencies
130 # are fixed.
131 "//mojo/edk/*",
132 ]
133 }
114 } 134 }
115 135
116 bundle_data(_bundle_data_executable) { 136 bundle_data(_bundle_data_executable) {
117 forward_variables_from(invoker, [ "testonly" ]) 137 forward_variables_from(invoker, [ "testonly" ])
118 visibility = [ ":$_target_name" ] 138 visibility = [ ":$_target_name" ]
119 sources = [ 139 sources = [
120 "$target_gen_dir/$_app_name", 140 "$target_gen_dir/$_app_name",
121 ] 141 ]
122 outputs = [ 142 outputs = [
123 "{{bundle_executable_dir}}/$_app_name", 143 "{{bundle_executable_dir}}/$_app_name",
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 bundle_executable_dir = bundle_root_dir 177 bundle_executable_dir = bundle_root_dir
158 bundle_plugins_dir = "$bundle_root_dir/Plugins" 178 bundle_plugins_dir = "$bundle_root_dir/Plugins"
159 } 179 }
160 180
161 # TODO(crbug.com/297668): 181 # TODO(crbug.com/297668):
162 # - add support for codesigning, 182 # - add support for codesigning,
163 # - find a way to make "ninja -C out/Default base_unittests.app" work as 183 # - find a way to make "ninja -C out/Default base_unittests.app" work as
164 # an alias to "ninja -C out/Default base_unittests" (for convenience 184 # an alias to "ninja -C out/Default base_unittests" (for convenience
165 # and compatibility with gyp), 185 # and compatibility with gyp),
166 } 186 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698