Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1801053002: Revert of Stop scheduling in-order script execution upon hitting failed script. (Closed)

Created:
4 years, 9 months ago by csharp
Modified:
4 years, 9 months ago
Reviewers:
haraken, sof
CC:
chromium-reviews, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Stop scheduling in-order script execution upon hitting failed script. (patchset #3 id:40001 of https://codereview.chromium.org/1798253002/ ) Reason for revert: This change seems to have broken the compile step of the WebKit Win non-Oilpan bot. Original issue's description: > Stop scheduling in-order script execution upon hitting failed script. > > R=haraken > BUG=581425 > > Committed: https://crrev.com/10cb02165d6d68a66007a3522f23a89fcb8a69d5 > Cr-Commit-Position: refs/heads/master@{#381217} TBR=haraken@chromium.org,sigbjornf@opera.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=581425 Committed: https://crrev.com/7cc158ee9df30b9f688f9742d69519d695cc6e3d Cr-Commit-Position: refs/heads/master@{#381218}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -27 lines) Patch
M third_party/WebKit/Source/core/dom/PendingScript.h View 3 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/PendingScript.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunner.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunner.cpp View 3 chunks +4 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
csharp
Created Revert of Stop scheduling in-order script execution upon hitting failed script.
4 years, 9 months ago (2016-03-15 14:00:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801053002/1
4 years, 9 months ago (2016-03-15 14:00:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-15 14:00:59 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7cc158ee9df30b9f688f9742d69519d695cc6e3d Cr-Commit-Position: refs/heads/master@{#381218}
4 years, 9 months ago (2016-03-15 14:02:16 UTC) #5
haraken
LGTM to revert.
4 years, 9 months ago (2016-03-15 14:12:19 UTC) #6
sof
lgtm, many thanks for the revert. seems to be MSVC local, https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oilpan_rel/builds/17523 didn't report trouble ...
4 years, 9 months ago (2016-03-15 14:12:42 UTC) #7
sof
On 2016/03/15 14:12:42, sof wrote: > lgtm, many thanks for the revert. > > seems ...
4 years, 9 months ago (2016-03-15 14:33:52 UTC) #8
sof
4 years, 9 months ago (2016-03-15 14:34:11 UTC) #9
Message was sent while issue was closed.
On 2016/03/15 14:12:42, sof wrote:
> lgtm, many thanks for the revert.
> 
> seems to be MSVC local,
>
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oi...
> didn't report trouble non-Oilpan.

Updated https://codereview.chromium.org/1798253002/ w/ alleged compile fix -
checking with the trybots.

Powered by Google App Engine
This is Rietveld 408576698