Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1800913002: Use GURLs instead of patterns for SetContentSetting in plugins (Closed)

Created:
4 years, 9 months ago by lshang
Modified:
4 years, 9 months ago
Reviewers:
Bernhard Bauer, raymes
CC:
chromium-reviews, jam, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use GURLs instead of patterns for SetContentSetting in plugins Migrate to use SetContentSettingDefaultScope() which takes GURLs only in plugins. For special test or specific patterns, remain to use SetContentSetting(). BUG=551747 Committed: https://crrev.com/38ac96539ffa5fc11696885b375c5a49d80fecae Cr-Commit-Position: refs/heads/master@{#381609}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M chrome/browser/plugins/plugin_info_message_filter_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
lshang
Hi raymes, PTAL thanks! SetContentSetting() on line 230 is unchanged since it's setting "foo" on ...
4 years, 9 months ago (2016-03-15 05:01:33 UTC) #3
raymes
lgtm
4 years, 9 months ago (2016-03-16 03:27:28 UTC) #4
lshang
+bauerb for OWNER review, thanks!
4 years, 9 months ago (2016-03-16 04:36:07 UTC) #6
Bernhard Bauer
lgtm
4 years, 9 months ago (2016-03-16 10:23:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800913002/1
4 years, 9 months ago (2016-03-17 00:00:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 00:41:30 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 00:42:24 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/38ac96539ffa5fc11696885b375c5a49d80fecae
Cr-Commit-Position: refs/heads/master@{#381609}

Powered by Google App Engine
This is Rietveld 408576698