Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1749)

Unified Diff: chrome/browser/plugins/plugin_info_message_filter_unittest.cc

Issue 1800913002: Use GURLs instead of patterns for SetContentSetting in plugins (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/plugins/plugin_info_message_filter_unittest.cc
diff --git a/chrome/browser/plugins/plugin_info_message_filter_unittest.cc b/chrome/browser/plugins/plugin_info_message_filter_unittest.cc
index d7d5c6ce689818e4f47dcc4a126c34f1d0a65c60..c66faa5d54ecd004dbeeed70e231af4cdc47089a 100644
--- a/chrome/browser/plugins/plugin_info_message_filter_unittest.cc
+++ b/chrome/browser/plugins/plugin_info_message_filter_unittest.cc
@@ -221,9 +221,8 @@ TEST_F(PluginInfoMessageFilterTest, GetPluginContentSetting) {
CONTENT_SETTING_BLOCK);
// Set plugins to Plugin Power Saver on example.com and subdomains.
- ContentSettingsPattern pattern =
- ContentSettingsPattern::FromString("[*.]example.com");
- map->SetContentSetting(pattern, ContentSettingsPattern::Wildcard(),
+ GURL host("http://example.com/");
+ map->SetContentSettingDefaultScope(host, GURL(),
CONTENT_SETTINGS_TYPE_PLUGINS, std::string(),
CONTENT_SETTING_DETECT_IMPORTANT_CONTENT);
@@ -235,7 +234,6 @@ TEST_F(PluginInfoMessageFilterTest, GetPluginContentSetting) {
CONTENT_SETTING_ALLOW);
GURL unmatched_host("https://www.google.com");
- GURL host("http://example.com/");
ASSERT_EQ(CONTENT_SETTING_BLOCK, map->GetContentSetting(
unmatched_host, unmatched_host, CONTENT_SETTINGS_TYPE_PLUGINS,
std::string()));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698