Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

Issue 18009003: Instant Extended: Delete unused overlay code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm b/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
index 0466c6176c5cb2e2fbc2e101362c53cf9e9fadf4..82032a1d5dbbe02489441d427ccf157dac7b3d0f 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
@@ -243,6 +243,7 @@ TEST_F(BrowserWindowControllerTest, TestIncognitoWidthSpace) {
#endif
namespace {
+
// Verifies that the toolbar, infobar, tab content area, and download shelf
// completely fill the area under the tabstrip.
void CheckViewPositions(BrowserWindowController* controller) {
@@ -255,10 +256,7 @@ void CheckViewPositions(BrowserWindowController* controller) {
EXPECT_EQ(NSMinY(contentView), NSMinY(download));
EXPECT_EQ(NSMaxY(download), NSMinY(contentArea));
-
- CGFloat min_toolbar_height = [[controller toolbarController]
- desiredHeightForCompression:1];
- EXPECT_EQ(NSMaxY(contentArea), NSMaxY(toolbar) - min_toolbar_height);
+ EXPECT_EQ(NSMaxY(contentArea), NSMinY(infobar));
// Bookmark bar frame is random memory when hidden.
if ([controller bookmarkBarVisible]) {
@@ -275,6 +273,7 @@ void CheckViewPositions(BrowserWindowController* controller) {
// not necessarily fixed with respect to the content view.
EXPECT_EQ(NSMinY(tabstrip), NSMaxY(toolbar));
}
+
} // end namespace
TEST_F(BrowserWindowControllerTest, TestAdjustWindowHeight) {

Powered by Google App Engine
This is Rietveld 408576698