Instant Extended: Delete unused overlay code

Instant Extended: Delete unused overlay code

This CL deletes unused overlay code. This code was used to display
an HTML popup above the bookmark bar. Now that we're using a native
omnibox popup we don't need this code anymore.

BUG=254670, 230574, 176585, 244211, 177747, 173836
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209013

[Robert Sesek, 2013-06-27 13:29:47]

https://codereview.chromium.org/18009003/diff/1/chrome/browser/renderer_host/...
File chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
(left):

https://codereview.chromium.org/18009003/diff/1/chrome/browser/renderer_host/...
chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm:283:
- (void)compositingIOSurfaceCreated {
Remove the method too?

https://codereview.chromium.org/18009003/diff/1/chrome/browser/ui/cocoa/brows...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

https://codereview.chromium.org/18009003/diff/1/chrome/browser/ui/cocoa/brows...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:230: // hidden. 
The find bar is unaffected by the side tab positioning.
Remove the bit about side tabs. I deleted that looong ago.

https://codereview.chromium.org/18009003/diff/1/chrome/browser/ui/cocoa/brows...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:856: // Toolbar is
below tab contents so that the infob arrow can appear above
infob -> infobar

https://codereview.chromium.org/18009003/diff/1/chrome/browser/ui/cocoa/dev_t...
File chrome/browser/ui/cocoa/dev_tools_controller.mm (left):

https://codereview.chromium.org/18009003/diff/1/chrome/browser/ui/cocoa/dev_t...
chrome/browser/ui/cocoa/dev_tools_controller.mm:159: [devToolsView
setAutoresizingMask:NSViewWidthSizable | NSViewHeightSizable];
Did you mean to remove the autoresizing mask?

[sail, 2013-06-27 18:26:03]

+avi for content/ OWNERS review.

https://codereview.chromium.org/18009003/diff/1/chrome/browser/renderer_host/...
File chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
(left):

https://codereview.chromium.org/18009003/diff/1/chrome/browser/renderer_host/...
chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm:283:
- (void)compositingIOSurfaceCreated {
On 2013/06/27 13:29:48, rsesek wrote:
> Remove the method too?

Done.

https://codereview.chromium.org/18009003/diff/1/chrome/browser/ui/cocoa/brows...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

https://codereview.chromium.org/18009003/diff/1/chrome/browser/ui/cocoa/brows...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:230: // hidden. 
The find bar is unaffected by the side tab positioning.
On 2013/06/27 13:29:48, rsesek wrote:
> Remove the bit about side tabs. I deleted that looong ago.

Done.

https://codereview.chromium.org/18009003/diff/1/chrome/browser/ui/cocoa/brows...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:856: // Toolbar is
below tab contents so that the infob arrow can appear above
On 2013/06/27 13:29:48, rsesek wrote:
> infob -> infobar

Done.

https://codereview.chromium.org/18009003/diff/1/chrome/browser/ui/cocoa/dev_t...
File chrome/browser/ui/cocoa/dev_tools_controller.mm (left):

https://codereview.chromium.org/18009003/diff/1/chrome/browser/ui/cocoa/dev_t...
chrome/browser/ui/cocoa/dev_tools_controller.mm:159: [devToolsView
setAutoresizingMask:NSViewWidthSizable | NSViewHeightSizable];
On 2013/06/27 13:29:48, rsesek wrote:
> Did you mean to remove the autoresizing mask?

Yea. I added the resizing mask when I put devToolsView inside a container view.
Normally the split view auto resizes the view to fit the pane.

[Avi (use Gerrit), 2013-06-27 18:34:37]

<meme type="cheering minions">
Native popup!
</meme>

Content LGTM

[Robert Sesek, 2013-06-27 18:45:38]

LGTM

https://codereview.chromium.org/18009003/diff/5001/content/browser/renderer_h...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

https://codereview.chromium.org/18009003/diff/5001/content/browser/renderer_h...
content/browser/renderer_host/render_widget_host_view_mac.mm:1240: bool
should_post_notification = false;
This variable is unused.

[sail, 2013-06-27 18:47:59]

https://codereview.chromium.org/18009003/diff/5001/content/browser/renderer_h...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

https://codereview.chromium.org/18009003/diff/5001/content/browser/renderer_h...
content/browser/renderer_host/render_widget_host_view_mac.mm:1240: bool
should_post_notification = false;
On 2013/06/27 18:45:38, rsesek wrote:
> This variable is unused.

Done.

[commit-bot: I haz the power, 2013-06-27 18:51:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/18009003/10002

[commit-bot: I haz the power, 2013-06-27 18:51:20]

Failed to apply patch for chrome/browser/ui/cocoa/fast_resize_view.mm:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/ui/cocoa/fast_resize_view.mm
  Hunk #1 succeeded at 16 with fuzz 2.
  Hunk #2 FAILED at 35.
  Hunk #3 FAILED at 77.
  2 out of 3 hunks FAILED -- saving rejects to file
chrome/browser/ui/cocoa/fast_resize_view.mm.rej

Patch:       chrome/browser/ui/cocoa/fast_resize_view.mm
Index: chrome/browser/ui/cocoa/fast_resize_view.mm
diff --git a/chrome/browser/ui/cocoa/fast_resize_view.mm
b/chrome/browser/ui/cocoa/fast_resize_view.mm
index
e87a3432974cb473a8f8138b17204fc2079d60d4..71cb27595e2cc79f6bff5a46dff148aab4f24250
100644
--- a/chrome/browser/ui/cocoa/fast_resize_view.mm
+++ b/chrome/browser/ui/cocoa/fast_resize_view.mm
@@ -16,8 +16,6 @@
 
 @implementation FastResizeView
 
-@synthesize contentOffset = contentOffset_;
-
 - (void)setFastResizeMode:(BOOL)fastResizeMode {
   fastResizeMode_ = fastResizeMode;
 
@@ -37,27 +35,14 @@
   if (!fastResizeMode_)
     return;
 
-  // Don't draw on the non-content area.
-  NSRect clipRect = [self bounds];
-  clipRect.size.height -= contentOffset_;
-  NSRectClip(clipRect);
-
   [[NSColor whiteColor] set];
   NSRectFill(dirtyRect);
 }
 
-- (NSView*)hitTest:(NSPoint)point {
-  NSView* result = [super hitTest:point];
-  // Never return this view during hit testing. This allows overlapping views
to
-  // get events even when they are not topmost.
-  if ([result isEqual:self])
-    return nil;
-  return result;
-}
-
 @end
 
 @implementation FastResizeView (PrivateMethods)
+
 - (void)layoutSubviews {
   // There should never be more than one subview.  There can be zero, if we are
   // in the process of switching tabs or closing the window.  In those cases,
no
@@ -79,4 +64,5 @@
     [subview setFrame:bounds];
   }
 }
+
 @end

[commit-bot: I haz the power, 2013-06-27 19:01:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/18009003/16001

[commit-bot: I haz the power, 2013-06-27 19:14:49]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[sail, 2013-06-27 19:22:52]

TBR thakis for chrome/browser/renderer_host/* OWNERS.

[commit-bot: I haz the power, 2013-06-27 19:24:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/18009003/16001

[Nico, 2013-06-27 19:29:27]

lgtm, but that doesn't look like a tbr'able chagne

[sail, 2013-06-27 22:20:46]

On 2013/06/27 19:29:27, Nico wrote:
> lgtm, but that doesn't look like a tbr'able chagne

Oops, sorry about that. Removed the TBR.

[commit-bot: I haz the power, 2013-06-27 22:29:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/18009003/16001

[commit-bot: I haz the power, 2013-06-27 22:32:06]

Change committed as 209013