Issue 1800793002: Modify xfa code to avoid c4800 warnings

Issue 1800793002: Modify xfa code to avoid c4800 warnings (Closed)

Created:
4 years, 9 months ago by Wei Li

Modified:
4 years, 9 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Modify xfa code to avoid c4800 warnings BUG=pdfium:29 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/e40764862208b8cb76f507c489b01e3795fd93bd

Patch Set 2 : address comments #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -19 lines)			Patch
M	core/fxge/ge/fx_ge_font.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/fpdfxfa/fpdfxfa_util.cpp	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	fpdfsdk/fsdk_baseform.cpp	View	1	1 chunk	+8 lines, -8 lines	0 comments	Download
M	fpdfsdk/include/fpdfxfa/fpdfxfa_util.h	View		2 chunks	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Wei Li

Missed clearing xfa code in last CL as it was not enabled in chromium code. ...

4 years, 9 months ago (2016-03-14 20:30:34 UTC) #2

Tom Sepez

lgtm https://codereview.chromium.org/1800793002/diff/1/fpdfsdk/fsdk_baseform.cpp File fpdfsdk/fsdk_baseform.cpp (right): https://codereview.chromium.org/1800793002/diff/1/fpdfsdk/fsdk_baseform.cpp#newcode353 fpdfsdk/fsdk_baseform.cpp:353: bool bChecked = pWidgetAcc->GetCheckState() == XFA_CHECKSTATE_On; nit: local ...

4 years, 9 months ago (2016-03-15 15:28:48 UTC) #3

Wei Li

thanks! https://codereview.chromium.org/1800793002/diff/1/fpdfsdk/fsdk_baseform.cpp File fpdfsdk/fsdk_baseform.cpp (right): https://codereview.chromium.org/1800793002/diff/1/fpdfsdk/fsdk_baseform.cpp#newcode353 fpdfsdk/fsdk_baseform.cpp:353: bool bChecked = pWidgetAcc->GetCheckState() == XFA_CHECKSTATE_On; On 2016/03/15 ...

4 years, 9 months ago (2016-03-15 17:58:14 UTC) #4

Wei Li

4 years, 9 months ago (2016-03-15 17:58:52 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
e40764862208b8cb76f507c489b01e3795fd93bd (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages