Modify xfa code to avoid c4800 warnings

fpdfsdk/fsdk_baseform.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "fpdfsdk/include/fsdk_baseform.h"
 
 #include <algorithm>
 #include <memory>
@@ skipping 332 matching lines @@
                                          CPDF_FormControl* pFormControl) {
   ASSERT(hWidget);
 
   if (IXFA_WidgetHandler* pXFAWidgetHandler = pXFADocView->GetWidgetHandler()) {
     ASSERT(pFormControl);
 
     switch (pFormField->GetFieldType()) {
       case FIELDTYPE_CHECKBOX: {
         if (CXFA_WidgetAcc* pWidgetAcc =
                 pXFAWidgetHandler->GetDataAcc(hWidget)) {
-          FX_BOOL bChecked = pWidgetAcc->GetCheckState() == XFA_CHECKSTATE_On;
-
-          pFormField->CheckControl(pFormField->GetControlIndex(pFormControl),
-                                   bChecked, TRUE);
+          pFormField->CheckControl(
+              pFormField->GetControlIndex(pFormControl),
+              pWidgetAcc->GetCheckState() == XFA_CHECKSTATE_On, true);
         }
       } break;
       case FIELDTYPE_RADIOBUTTON: {
+        // TODO(weili): Check whether we need to handle checkbox and radio
+        // button differently, otherwise, merge these two cases.
         if (CXFA_WidgetAcc* pWidgetAcc =
                 pXFAWidgetHandler->GetDataAcc(hWidget)) {
-          FX_BOOL bChecked = pWidgetAcc->GetCheckState() == XFA_CHECKSTATE_On;
-
-          pFormField->CheckControl(pFormField->GetControlIndex(pFormControl),
-                                   bChecked, TRUE);
+          pFormField->CheckControl(
+              pFormField->GetControlIndex(pFormControl),
+              pWidgetAcc->GetCheckState() == XFA_CHECKSTATE_On, true);
         }
       } break;
       case FIELDTYPE_TEXTFIELD: {
         if (CXFA_WidgetAcc* pWidgetAcc =
                 pXFAWidgetHandler->GetDataAcc(hWidget)) {
           CFX_WideString sValue;
           pWidgetAcc->GetValue(sValue, XFA_VALUEPICTURE_Display);
           pFormField->SetValue(sValue, TRUE);
         }
       } break;
@@ skipping 2487 matching lines @@
       break;
     }
   }
 }
 
 CFX_FloatRect CBA_AnnotIterator::GetAnnotRect(const CPDFSDK_Annot* pAnnot) {
   CFX_FloatRect rcAnnot;
   pAnnot->GetPDFAnnot()->GetRect(rcAnnot);
   return rcAnnot;
 }