mojo/public/cpp/bindings/tests/union_unittest.cc - Issue 1800753005: C++ bindings: A struct's Deserialize() now does validation before deserializing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/tests/union_unittest.cc

Issue 1800753005: C++ bindings: A struct's Deserialize() now does validation before deserializing. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Address comments. DeserializeWithoutValidation returns void, doesn't take in buf_size. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/cpp/bindings/tests/serialization_api_unittest.cc ('K') | « mojo/public/cpp/bindings/tests/serialization_api_unittest.cc ('k') | mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl » ('j') | mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/bindings/tests/union_unittest.cc

diff --git a/mojo/public/cpp/bindings/tests/union_unittest.cc b/mojo/public/cpp/bindings/tests/union_unittest.cc

index 95a2d7fd43bd4dbb322fa1d8483c1036e0495f2a..6be7945227166aa3f5cb253fddb22e7612b0b031 100644

--- a/mojo/public/cpp/bindings/tests/union_unittest.cc

+++ b/mojo/public/cpp/bindings/tests/union_unittest.cc

@@ -661,8 +661,7 @@ TEST(UnionTest, Deserialize_NullableUnion) {

EXPECT_TRUE(small_struct->pod_union.is_null());

SmallStructPtr deserialized_struct = SmallStruct::New();

- deserialized_struct->Deserialize(buf);

+ EXPECT_TRUE(deserialized_struct->Deserialize(buf, sizeof(buf)));

EXPECT_TRUE(deserialized_struct->pod_union.is_null());

}