mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl - Issue 1800753005: C++ bindings: A struct's Deserialize() now does validation before deserializing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

Issue 1800753005: C++ bindings: A struct's Deserialize() now does validation before deserializing. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Address comments. DeserializeWithoutValidation returns void, doesn't take in buf_size. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/cpp/bindings/tests/serialization_api_unittest.cc ('K') | « mojo/public/cpp/bindings/tests/union_unittest.cc ('k') | mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl » ('j') | mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

index c25d35eaef13d2ba55cdb3e410d1ec6225f00c57..c0b79e6e22c1c89ca25535ef60c1fb98cd479f3c 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

@@ -280,4 +280,4 @@ using {{struct.name}}Ptr = mojo::InlinedStructPtr<{{struct.name}}>;

{% else %}

using {{struct.name}}Ptr = mojo::StructPtr<{{struct.name}}>;

{% endif %}

-{% endmacro %}

+{% endmacro %}