mojo/public/cpp/bindings/lib/validation_errors.h - Issue 1800753005: C++ bindings: A struct's Deserialize() now does validation before deserializing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/lib/validation_errors.h

Issue 1800753005: C++ bindings: A struct's Deserialize() now does validation before deserializing. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Address comments. DeserializeWithoutValidation returns void, doesn't take in buf_size. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/cpp/bindings/lib/bindings_internal.h ('K') | « mojo/public/cpp/bindings/lib/fixed_buffer.h ('k') | mojo/public/cpp/bindings/tests/serialization_api_unittest.cc » ('j') | mojo/public/cpp/bindings/tests/serialization_api_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/bindings/lib/validation_errors.h

diff --git a/mojo/public/cpp/bindings/lib/validation_errors.h b/mojo/public/cpp/bindings/lib/validation_errors.h

index d15233335f18c301dce4c11c736fc66f2481f812..da8fa3f67b99fe29167412de5504ff220a989423 100644

--- a/mojo/public/cpp/bindings/lib/validation_errors.h

+++ b/mojo/public/cpp/bindings/lib/validation_errors.h

@@ -63,6 +63,7 @@ enum class ValidationError {

const char* ValidationErrorToString(ValidationError error);

+// TODO(vardhan): This can die, along with |ValidationErrorObserverForTesting|.

void ReportValidationError(ValidationError error,

std::string* description = nullptr);