mojo/public/cpp/bindings/lib/bindings_internal.h - Issue 1800753005: C++ bindings: A struct's Deserialize() now does validation before deserializing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/lib/bindings_internal.h

Issue 1800753005: C++ bindings: A struct's Deserialize() now does validation before deserializing. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Address comments. DeserializeWithoutValidation returns void, doesn't take in buf_size. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « examples/serialization/main.cc ('k') | mojo/public/cpp/bindings/lib/fixed_buffer.h » ('j') | mojo/public/cpp/bindings/tests/serialization_api_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/bindings/lib/bindings_internal.h

diff --git a/mojo/public/cpp/bindings/lib/bindings_internal.h b/mojo/public/cpp/bindings/lib/bindings_internal.h

index 7889fa6f9365d01354d50a9f56e453bdfcf9cf76..39d13bc8384606efba931cc491467430880651c3 100644

--- a/mojo/public/cpp/bindings/lib/bindings_internal.h

+++ b/mojo/public/cpp/bindings/lib/bindings_internal.h

@@ -98,6 +98,8 @@ struct IsHandle {

enum { value = std::is_base_of<Handle, H>::value };

};

+// TODO(vardhan): Should RemoveStructPtr<> be internal-only? Should be /the/ way

viettrungluu 2016/03/30 17:49:01 Hmmm. Or is specializing std::pointer_traits the r

vardhan 2016/03/30 22:49:07 yeah, good point; std::pointer_traits will defini

+// to get T from StructPtr<T>?

template <typename T>

struct RemoveStructPtr {

typedef T type;