content/public/test/test_notification_tracker.h - Issue 18006003: Consistently use notifications from component updater w/ on-demand PNaCl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/test_notification_tracker.h

Issue 18006003: Consistently use notifications from component updater w/ on-demand PNaCl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: cleanup test a bit Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/component_updater/pnacl/pnacl_updater_observer.cc ('K') | « chrome/browser/component_updater/test/component_updater_service_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/test/test_notification_tracker.h

diff --git a/content/public/test/test_notification_tracker.h b/content/public/test/test_notification_tracker.h

index f34fdae614da5b8acd16eea4985cab6c5b41bda9..fd64f83f03344e61d29cf228013d1fa375f8cce3 100644

--- a/content/public/test/test_notification_tracker.h

+++ b/content/public/test/test_notification_tracker.h

@@ -43,7 +43,7 @@ class TestNotificationTracker : public NotificationObserver {

void ListenForAll(int type);

// Clears the list of events.

- void Reset();

+ virtual void Reset();

cpu_(ooo_6.6-7.5) 2013/07/01 18:30:22 if we need virtual here, I expect to see some code

jvoung (off chromium) 2013/07/02 01:04:26 Is line 107 of: https://codereview.chromium.org/1

// Given notifications type(sp, returns true if the list of notifications

// were exactly those listed in the given arg(s), and in the same order.