Consistently use notifications from component updater w/ on-demand PNaCl.

content/public/test/test_notification_tracker.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_TEST_TEST_NOTIFICATION_TRACKER_H_
 #define CONTENT_PUBLIC_TEST_TEST_NOTIFICATION_TRACKER_H_
 
 #include <vector>
 
 #include "base/compiler_specific.h"
@@ skipping 25 matching lines @@
   virtual ~TestNotificationTracker();
 
   // Makes this object listen for the given notification with the given source.
   void ListenFor(int type, const NotificationSource& source);
 
   // Makes this object listen for notifications of the given type coming from
   // any source.
   void ListenForAll(int type);
 
   // Clears the list of events.
-  void Reset();
+  virtual void Reset();
 

[cpu_(ooo_6.6-7.5), 2013/07/01 18:30:22]

if we need virtual here, I expect to see some code overriding it with the
OVERRIDE at the end of the declaration, but such code is not in the CL.

[jvoung (off chromium), 2013/07/02 01:04:26]

Is line 107 of:

https://codereview.chromium.org/18006003/diff/39001/chrome/browser/component_...

what you are looking for?

   // Given notifications type(sp, returns true if the list of notifications
   // were exactly those listed in the given arg(s), and in the same order.
   //
   // This will also reset the list so that the next call will only check for
   // new notifications. Example:
   //   <do stuff>
   //   Check1AndReset(NOTIFY_A);
   //   <do stuff>
   //   Check2AndReset(NOTIFY_B, NOTIFY_C)
   bool Check1AndReset(int type);
@@ skipping 19 matching lines @@
 
   // Lists all received since last cleared, in the order they were received.
   std::vector<Event> events_;
 
   DISALLOW_COPY_AND_ASSIGN(TestNotificationTracker);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_TEST_TEST_NOTIFICATION_TRACKER_H_