Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: Source/core/rendering/RenderLayerCompositor.cpp

Issue 18005002: Refactoring RenderLayerCompositor to avoid redundant checks for Compositing reasons (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderLayerCompositor.cpp
diff --git a/Source/core/rendering/RenderLayerCompositor.cpp b/Source/core/rendering/RenderLayerCompositor.cpp
index f472d127bcb8eb2dfaba789a65cf4fab397f1700..dd4213d8d72325d6edda73de91047d626d054ac7 100644
--- a/Source/core/rendering/RenderLayerCompositor.cpp
+++ b/Source/core/rendering/RenderLayerCompositor.cpp
@@ -1574,16 +1574,14 @@ CompositingReasons RenderLayerCompositor::directReasonsForCompositing(const Rend
if (requiresCompositingForTransform(renderer))
directReasons |= CompositingReason3DTransform;
+ // Only zero or one of the following conditions will be true for a given RenderLayer.
if (requiresCompositingForVideo(renderer))
directReasons |= CompositingReasonVideo;
-
- if (requiresCompositingForCanvas(renderer))
+ else if (requiresCompositingForCanvas(renderer))
directReasons |= CompositingReasonCanvas;
-
- if (requiresCompositingForPlugin(renderer))
+ else if (requiresCompositingForPlugin(renderer))
directReasons |= CompositingReasonPlugin;
-
- if (requiresCompositingForFrame(renderer))
+ else if (requiresCompositingForFrame(renderer))
directReasons |= CompositingReasonIFrame;
if (requiresCompositingForBackfaceVisibilityHidden(renderer))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698