Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Side by Side Diff: Source/core/rendering/RenderLayerCompositor.cpp

Issue 18005002: Refactoring RenderLayerCompositor to avoid redundant checks for Compositing reasons (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 1556 matching lines...) Expand 10 before | Expand all | Expand 10 after
1567 } 1567 }
1568 1568
1569 CompositingReasons RenderLayerCompositor::directReasonsForCompositing(const Rend erLayer* layer) const 1569 CompositingReasons RenderLayerCompositor::directReasonsForCompositing(const Rend erLayer* layer) const
1570 { 1570 {
1571 RenderObject* renderer = layer->renderer(); 1571 RenderObject* renderer = layer->renderer();
1572 CompositingReasons directReasons = CompositingReasonNone; 1572 CompositingReasons directReasons = CompositingReasonNone;
1573 1573
1574 if (requiresCompositingForTransform(renderer)) 1574 if (requiresCompositingForTransform(renderer))
1575 directReasons |= CompositingReason3DTransform; 1575 directReasons |= CompositingReason3DTransform;
1576 1576
1577 // Only zero or one of the following conditions will be true for a given Ren derLayer.
1577 if (requiresCompositingForVideo(renderer)) 1578 if (requiresCompositingForVideo(renderer))
1578 directReasons |= CompositingReasonVideo; 1579 directReasons |= CompositingReasonVideo;
1579 1580 else if (requiresCompositingForCanvas(renderer))
1580 if (requiresCompositingForCanvas(renderer))
1581 directReasons |= CompositingReasonCanvas; 1581 directReasons |= CompositingReasonCanvas;
1582 1582 else if (requiresCompositingForPlugin(renderer))
1583 if (requiresCompositingForPlugin(renderer))
1584 directReasons |= CompositingReasonPlugin; 1583 directReasons |= CompositingReasonPlugin;
1585 1584 else if (requiresCompositingForFrame(renderer))
1586 if (requiresCompositingForFrame(renderer))
1587 directReasons |= CompositingReasonIFrame; 1585 directReasons |= CompositingReasonIFrame;
1588 1586
1589 if (requiresCompositingForBackfaceVisibilityHidden(renderer)) 1587 if (requiresCompositingForBackfaceVisibilityHidden(renderer))
1590 directReasons |= CompositingReasonBackfaceVisibilityHidden; 1588 directReasons |= CompositingReasonBackfaceVisibilityHidden;
1591 1589
1592 if (requiresCompositingForAnimation(renderer)) 1590 if (requiresCompositingForAnimation(renderer))
1593 directReasons |= CompositingReasonAnimation; 1591 directReasons |= CompositingReasonAnimation;
1594 1592
1595 if (requiresCompositingForTransition(renderer)) 1593 if (requiresCompositingForTransition(renderer))
1596 directReasons |= CompositingReasonAnimation; 1594 directReasons |= CompositingReasonAnimation;
(...skipping 1155 matching lines...) Expand 10 before | Expand all | Expand 10 after
2752 info.addMember(m_layerForScrollCorner, "layerForScrollCorner"); 2750 info.addMember(m_layerForScrollCorner, "layerForScrollCorner");
2753 #if ENABLE(RUBBER_BANDING) 2751 #if ENABLE(RUBBER_BANDING)
2754 info.addMember(m_layerForOverhangAreas, "layerForOverhangAreas"); 2752 info.addMember(m_layerForOverhangAreas, "layerForOverhangAreas");
2755 info.addMember(m_contentShadowLayer, "contentShadowLayer"); 2753 info.addMember(m_contentShadowLayer, "contentShadowLayer");
2756 info.addMember(m_layerForTopOverhangArea, "layerForTopOverhangArea"); 2754 info.addMember(m_layerForTopOverhangArea, "layerForTopOverhangArea");
2757 info.addMember(m_layerForBottomOverhangArea, "layerForBottomOverhangArea"); 2755 info.addMember(m_layerForBottomOverhangArea, "layerForBottomOverhangArea");
2758 #endif 2756 #endif
2759 } 2757 }
2760 2758
2761 } // namespace WebCore 2759 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698