Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1800393002: RecreateLayer should copy the transform as well. (Closed)

Created:
4 years, 9 months ago by oshima
Modified:
4 years, 9 months ago
Reviewers:
danakj
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

RecreateLayer should copy the transform as well. BUG=581917 TEST=LayerOwnerTest.RecreateLayerWithTransform Committed: https://crrev.com/e083cc6e0b6d6e0e345b553041f2e241aca5e448 Cr-Commit-Position: refs/heads/master@{#381571}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M ui/compositor/layer_owner.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/layer_owner_unittest.cc View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
oshima
4 years, 9 months ago (2016-03-16 01:42:21 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800393002/1
4 years, 9 months ago (2016-03-16 01:42:46 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-16 05:20:36 UTC) #6
oshima
vollick@ seems to be OOO. danakj@ can you review this?
4 years, 9 months ago (2016-03-16 21:46:53 UTC) #8
danakj
LGTM
4 years, 9 months ago (2016-03-16 21:50:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800393002/1
4 years, 9 months ago (2016-03-16 22:26:00 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 22:33:00 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 22:35:40 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e083cc6e0b6d6e0e345b553041f2e241aca5e448
Cr-Commit-Position: refs/heads/master@{#381571}

Powered by Google App Engine
This is Rietveld 408576698