third_party/WebKit/Source/modules/webgl/WebGLTimerQueryEXT.cpp - Issue 1800383002: Disable timestamps in WebGL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLTimerQueryEXT.cpp

Issue 1800383002: Disable timestamps in WebGL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mark the test as no longer flaky Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQuery.cpp ('K') | « third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLTimerQueryEXT.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLTimerQueryEXT.cpp b/third_party/WebKit/Source/modules/webgl/WebGLTimerQueryEXT.cpp

index e4518f11d3004f9b0fc04784cede656a1885951c..16a0fb913fdf85d178d21e49574bb2c99242fc53 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLTimerQueryEXT.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLTimerQueryEXT.cpp

@@ -56,6 +56,13 @@ void WebGLTimerQueryEXT::updateCachedResult(WebGraphicsContext3D* ctx)

if (!hasTarget())

return;

+ // If this is a timestamp query, set the result to 0 and make it available as we don't support timestamps in WebGL due to very poor driver support for them

+ if (m_target == GL_TIMESTAMP_EXT) {

+ m_queryResult = 0;

+ m_queryResultAvailable = true;

+ return;

+ }

// We can only update the cached result when control returns to the browser.

m_canUpdateAvailability = false;

GLuint available = 0;