third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQuery.cpp - Issue 1800383002: Disable timestamps in WebGL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQuery.cpp

Issue 1800383002: Disable timestamps in WebGL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mark the test as no longer flaky Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQuery.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQuery.cpp b/third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQuery.cpp

index 29f6521ecc1ccef648faecd9db1fff387a4e9aab..f6d502bd02df11cd510e3e0fcfe5439a9427dcbf 100644

--- a/third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQuery.cpp

+++ b/third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQuery.cpp

@@ -140,7 +140,7 @@ void EXTDisjointTimerQuery::queryCounterEXT(WebGLTimerQueryEXT* query, GLenum ta

return;

}

- scoped.context()->webContext()->queryCounterEXT(query->object(), target);

+ // Timestamps are disabled in WebGL due to lack of driver support, so we don't actually perform a GL call

Ken Russell (switch to Gerrit) 2016/03/24 17:02:26 Let's clarify "due to lack of driver support on mu

query->setTarget(target);

query->resetCachedResult();

}