Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4651)

Unified Diff: chrome/test/data/extensions/samples/bookmarks/bookmark_view.html

Issue 180016: Extension API Renaming/Consistency changes (Closed)
Patch Set: render docs Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/samples/bookmarks/bookmark_view.html
diff --git a/chrome/test/data/extensions/samples/bookmarks/bookmark_view.html b/chrome/test/data/extensions/samples/bookmarks/bookmark_view.html
index 5275f37f496ae33c29683f36a27daf915dcd2c7e..163f2e48f51ef85c71fb7e242628fda879b0b7f9 100644
--- a/chrome/test/data/extensions/samples/bookmarks/bookmark_view.html
+++ b/chrome/test/data/extensions/samples/bookmarks/bookmark_view.html
@@ -43,8 +43,8 @@ var logEvent = function(name, id, data) {
console.log("got event: " + name);
}
-chrome.bookmarks.onAdded.addListener(function(id, data) {
- logEvent("onBookmarkAdded", id, data);
+chrome.bookmarks.onCreated.addListener(function(id, data) {
+ logEvent("onBookmarkCreated", id, data);
});
chrome.bookmarks.onRemoved.addListener(function(id, data) {
@@ -71,9 +71,7 @@ var toggleBookmark = function(event) {
var id_str = node.id;
if (id_str < prefix.length)
return;
- var id = parseInt(id_str.substring(prefix.length));
- if (id == NaN)
- return;
+ var id = id_str.substring(prefix.length);
console.log("toggle: " + id);
//console.dir(event);
if (node.childNodes.length > 1) {
@@ -136,7 +134,7 @@ var testGetTree = function(results) {
var loadBookmarks = function() {
var container = document.getElementById('container');
var rootElement = document.createElement("div");
- var rootId = 0;
+ var rootId = '0';
rootElement.id = prefix + rootId;
// root element is empty / invisible, just an id to be looked up
container.appendChild(rootElement);

Powered by Google App Engine
This is Rietveld 408576698