Issue 1800083002: [iOS] Remove dependencies on //jingle from //components/invalidation/impl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1800083002: [iOS] Remove dependencies on //jingle from //components/invalidation/impl. (Closed)

Created:
4 years, 9 months ago by sdefresne

Modified:
4 years, 9 months ago

Reviewers:
pavely

CC:
chromium-reviews, Dirk Pranke

Base URL:
https://chromium.googlesource.com/chromium/src.git@components

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[iOS] Remove dependencies on //jingle from //components/invalidation/impl. //components/invalidation/impl depends on //jingle which in turns depends on //third_party/webrtc that cannot be build on iOS. Stop building on iOS the files that depends on //jingle. BUG=459705

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -28 lines)			Patch
	M	components/invalidation/impl/BUILD.gn	View		9 chunks	+44 lines, -28 lines	0 comments	Download

Dependent Patchsets:

Issue 1801083002 Patch 1

Issue 1801083002 Patch 20001

Issue 1812823002 Patch 1

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

pavely

Do you need to do similar changes in components/invalidation.gypi?

4 years, 9 months ago (2016-03-15 17:50:29 UTC) #3

sdefresne

4 years, 9 months ago (2016-03-18 15:51:29 UTC) #4

Message was sent while issue was closed.

On 2016/03/15 at 17:50:29, pavely wrote:
> Do you need to do similar changes in components/invalidation.gypi?

It was a temporary "fix" until I figured how to fix //jingle compilation on iOS.
Thanks to visiting kjellander@, we figured that the correct fix is
https://codereview.webrtc.org/1812213002.

Closing this CL as obsolete.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages