Source/core/dom/StyleEngine.cpp - Issue 180003002: Consistently use on-heap collections for StyleRuleBase descendants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/StyleEngine.cpp

Issue 180003002: Consistently use on-heap collections for StyleRuleBase descendants. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: addressed reviewers comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/StyleEngine.cpp

diff --git a/Source/core/dom/StyleEngine.cpp b/Source/core/dom/StyleEngine.cpp

index f9b8c45508b20637e5c1211dcb5ee46d8fa5dff3..b6039f24e915b4076cf8a381553f93d5f45cff88 100644

--- a/Source/core/dom/StyleEngine.cpp

+++ b/Source/core/dom/StyleEngine.cpp

@@ -539,7 +539,7 @@ void StyleEngine::updateGenericFontFamilySettings()

m_resolver->invalidateMatchedPropertiesCache();

}

-void StyleEngine::removeFontFaceRules(const Vector<const StyleRuleFontFace*>& fontFaceRules)

+void StyleEngine::removeFontFaceRules(const WillBeHeapVector<RawPtrWillBeMember<const StyleRuleFontFace> >& fontFaceRules)

{

if (!m_fontSelector)

return;