Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: Source/core/css/StyleSheetContents.h

Issue 180003002: Consistently use on-heap collections for StyleRuleBase descendants. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: addressed reviewers comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/StyleRuleImport.cpp ('k') | Source/core/css/StyleSheetContents.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/StyleSheetContents.h
diff --git a/Source/core/css/StyleSheetContents.h b/Source/core/css/StyleSheetContents.h
index 1807fdf45143f8b8a746286ef4bb03596d47b60e..b9eb3842c10e5843e90e5a12f0c6a6d6bfa41f39 100644
--- a/Source/core/css/StyleSheetContents.h
+++ b/Source/core/css/StyleSheetContents.h
@@ -95,7 +95,7 @@ public:
void setHasFontFaceRule(bool b) { m_hasFontFaceRule = b; }
bool hasFontFaceRule() const { return m_hasFontFaceRule; }
- void findFontFaceRules(Vector<const StyleRuleFontFace*>& fontFaceRules);
+ void findFontFaceRules(WillBeHeapVector<RawPtrWillBeMember<const StyleRuleFontFace> >& fontFaceRules);
void parserAddNamespace(const AtomicString& prefix, const AtomicString& uri);
void parserAppendRule(PassRefPtrWillBeRawPtr<StyleRuleBase>);
@@ -114,7 +114,7 @@ public:
StyleSheetContents* parentStyleSheet() const;
StyleRuleImport* ownerRule() const { return m_ownerRule; }
- void clearOwnerRule() { m_ownerRule = 0; }
+ void clearOwnerRule() { m_ownerRule = nullptr; }
haraken 2014/02/26 13:23:49 Shall we add #if ENABLE(OILPAN) ?
Vyacheslav Egorov (Chromium) 2014/02/26 13:47:11 setCSSStyleSheet() calls this so I can't do that.
// Note that href is the URL that started the redirect chain that led to
// this style sheet. This property probably isn't useful for much except
@@ -165,7 +165,7 @@ private:
void clearCharsetRule();
- StyleRuleImport* m_ownerRule;
+ RawPtrWillBeMember<StyleRuleImport> m_ownerRule;
String m_originalURL;
« no previous file with comments | « Source/core/css/StyleRuleImport.cpp ('k') | Source/core/css/StyleSheetContents.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698