Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: Source/core/css/RuleSet.h

Issue 180003002: Consistently use on-heap collections for StyleRuleBase descendants. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: addressed reviewers comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/RuleSet.h
diff --git a/Source/core/css/RuleSet.h b/Source/core/css/RuleSet.h
index ae8be246917f482e85ccc1019c562beb5872413e..8b259bd506f9aa49bbb8eb97a5f5b349cc5ac54d 100644
--- a/Source/core/css/RuleSet.h
+++ b/Source/core/css/RuleSet.h
@@ -133,10 +133,10 @@ public:
const Vector<RuleData>* cuePseudoRules() const { ASSERT(!m_pendingRules); return &m_cuePseudoRules; }
const Vector<RuleData>* focusPseudoClassRules() const { ASSERT(!m_pendingRules); return &m_focusPseudoClassRules; }
const Vector<RuleData>* universalRules() const { ASSERT(!m_pendingRules); return &m_universalRules; }
- const Vector<StyleRulePage*>& pageRules() const { ASSERT(!m_pendingRules); return m_pageRules; }
- const Vector<StyleRuleViewport*>& viewportRules() const { ASSERT(!m_pendingRules); return m_viewportRules; }
- const Vector<StyleRuleFontFace*>& fontFaceRules() const { return m_fontFaceRules; }
- const Vector<StyleRuleKeyframes*>& keyframesRules() const { return m_keyframesRules; }
+ const WillBeHeapVector<RawPtrWillBeMember<StyleRulePage> >& pageRules() const { ASSERT(!m_pendingRules); return m_pageRules; }
+ const WillBeHeapVector<RawPtrWillBeMember<StyleRuleViewport> >& viewportRules() const { ASSERT(!m_pendingRules); return m_viewportRules; }
+ const WillBeHeapVector<RawPtrWillBeMember<StyleRuleFontFace> >& fontFaceRules() const { return m_fontFaceRules; }
+ const WillBeHeapVector<RawPtrWillBeMember<StyleRuleKeyframes> >& keyframesRules() const { return m_keyframesRules; }
const Vector<MinimalRuleData>& treeBoundaryCrossingRules() const { return m_treeBoundaryCrossingRules; }
const Vector<MinimalRuleData>& shadowDistributedRules() const { return m_shadowDistributedRules; }
const MediaQueryResultList& viewportDependentMediaQueryResults() const { return m_viewportDependentMediaQueryResults; }
@@ -206,10 +206,10 @@ private:
Vector<RuleData> m_focusPseudoClassRules;
Vector<RuleData> m_universalRules;
RuleFeatureSet m_features;
- Vector<StyleRulePage*> m_pageRules;
- Vector<StyleRuleViewport*> m_viewportRules;
- Vector<StyleRuleFontFace*> m_fontFaceRules;
- Vector<StyleRuleKeyframes*> m_keyframesRules;
+ WillBePersistentHeapVector<RawPtrWillBeMember<StyleRulePage> > m_pageRules;
+ WillBePersistentHeapVector<RawPtrWillBeMember<StyleRuleViewport> > m_viewportRules;
+ WillBePersistentHeapVector<RawPtrWillBeMember<StyleRuleFontFace> > m_fontFaceRules;
+ WillBePersistentHeapVector<RawPtrWillBeMember<StyleRuleKeyframes> > m_keyframesRules;
Vector<MinimalRuleData> m_treeBoundaryCrossingRules;
Vector<MinimalRuleData> m_shadowDistributedRules;

Powered by Google App Engine
This is Rietveld 408576698