Source/core/css/PageRuleCollector.h - Issue 180003002: Consistently use on-heap collections for StyleRuleBase descendants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/PageRuleCollector.h

Issue 180003002: Consistently use on-heap collections for StyleRuleBase descendants. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: addressed reviewers comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/PageRuleCollector.h

diff --git a/Source/core/css/PageRuleCollector.h b/Source/core/css/PageRuleCollector.h

index 83251612aaffbd71d0e8df4636bf19d3c3a5576c..f71782796ee3b883028f9fa9a703ab3f6e2d143f 100644

--- a/Source/core/css/PageRuleCollector.h

+++ b/Source/core/css/PageRuleCollector.h

@@ -43,7 +43,7 @@ private:

bool isFirstPage(int pageIndex) const;

String pageName(int pageIndex) const;

- void matchPageRulesForList(Vector<StyleRulePage*>& matchedRules, const Vector<StyleRulePage*>& rules, bool isLeftPage, bool isFirstPage, const String& pageName);

+ void matchPageRulesForList(WillBeHeapVector<RawPtrWillBeMember<StyleRulePage> >& matchedRules, const WillBeHeapVector<RawPtrWillBeMember<StyleRulePage> >& rules, bool isLeftPage, bool isFirstPage, const String& pageName);

const bool m_isLeftPage;

const bool m_isFirstPage;

« no previous file with comments | « Source/core/css/ElementRuleCollector.h ('k') | Source/core/css/PageRuleCollector.cpp » ('j') | Source/core/css/StyleSheetContents.h » ('J')