Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: ios/web/web_state/web_view_internal_creation_util.h

Issue 1799843002: Removing StaticFileWebView vending methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/web_state/web_view_internal_creation_util.h
diff --git a/ios/web/web_state/web_view_internal_creation_util.h b/ios/web/web_state/web_view_internal_creation_util.h
index 0c8235bd1fff1580565c41e70fbbb7e19bc5f6ca..eedcccb1d8b23ed68424ac797ffa7ea44d2befea 100644
--- a/ios/web/web_state/web_view_internal_creation_util.h
+++ b/ios/web/web_state/web_view_internal_creation_util.h
@@ -63,43 +63,10 @@ WKWebView* CreateWKWebView(CGRect frame,
NSUInteger GetActiveWKWebViewsCount();
// Returns a CRWSimpleWebViewController for managing/showing a web view.
-// The BrowsingDataPartition must be synchronized before this method is called.
// Note: Callers are responsible for releasing the CRWSimpleWebViewController.
-// DEPRECATED: The usage of |WebViewType| param is deprecated.
-// TODO(crbug.com/579697): By default the controller is backed by a WKWebView.
-// Remove the |WebViewType| param once all clients have stopped using it.
id<CRWSimpleWebViewController> CreateSimpleWebViewController(
CGRect frame,
- BrowserState* browser_state,
- WebViewType web_view_type = WK_WEB_VIEW_TYPE);
-
-// Returns a new CRWSimpleWebViewController subclass displaying static HTML file
-// content stored in the application bundle.
-// The BrowsingDataPartition must be synchronized before this method is called.
-// Note: Callers are responsible for releasing the returned ViewController.
-// TODO(crbug.com/579697): By default the controller is backed by a WKWebView.
-// Remove the |WebViewType| param once all clients have stopped using it.
-id<CRWSimpleWebViewController> CreateStaticFileSimpleWebViewController(
- CGRect frame,
- BrowserState* browser_state,
- WebViewType web_view_type = WK_WEB_VIEW_TYPE);
-
-// Returns a new UIWebView subclass for displaying static HTML file content
-// stored in the application bundle. if |browser_state| is nullptr, requests
-// from the returned UIWebView will be done with global request context. When
-// requests are made with global request context, requests such as file://
-// will fail.
-// Note: Callers are responsible for releasing the returned UIWebView.
-// DEPRECATED: Please use the |CreateStaticFileSimpleWebViewController|
-// equivalent instead.
-UIWebView* CreateStaticFileWebView(CGRect frame, BrowserState* browser_state);
-
-// A convenience method that returns a static file web view with
-// CGRectZero and |nullptr| browser state.
-// Note: Callers are responsible for releasing the returned UIWebView.
-// DEPRECATED: Please use the |CreateStaticFileSimpleWebViewController|
-// equivalent instead.
-UIWebView* CreateStaticFileWebView();
+ BrowserState* browser_state);
#if !defined(NDEBUG)
// Returns true if the creation of web views using alloc, init has been allowed

Powered by Google App Engine
This is Rietveld 408576698