Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: ios/web/web_state/web_view_internal_creation_util.mm

Issue 1799843002: Removing StaticFileWebView vending methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/web_state/web_view_internal_creation_util.mm
diff --git a/ios/web/web_state/web_view_internal_creation_util.mm b/ios/web/web_state/web_view_internal_creation_util.mm
index cde21764517e72ef6eb1c50bb2781036e1913555..ad4598d5216767b708ded4d72cc7c55f6f473bca 100644
--- a/ios/web/web_state/web_view_internal_creation_util.mm
+++ b/ios/web/web_state/web_view_internal_creation_util.mm
@@ -209,39 +209,6 @@ id<CRWSimpleWebViewController> CreateSimpleWebViewController(
return [[CRWUISimpleWebViewController alloc] initWithUIWebView:web_view];
}
-id<CRWSimpleWebViewController> CreateStaticFileSimpleWebViewController(
- CGRect frame,
- BrowserState* browser_state,
- WebViewType web_view_type) {
- DCHECK(web::BrowsingDataPartition::IsSynchronized());
-
- // Transparently return the correct subclass.
- if (web_view_type == WK_WEB_VIEW_TYPE) {
- // TOOD(shreyasv): Create a new util function vending a WKWebView, wrap that
- // now return the UIWebView version. crbug.com/403634.
- }
- base::scoped_nsobject<UIWebView> staticFileWebView(
- CreateStaticFileWebView(frame, browser_state));
- return [[CRWUISimpleWebViewController alloc]
- initWithUIWebView:staticFileWebView];
-}
-
-UIWebView* CreateStaticFileWebView(CGRect frame, BrowserState* browser_state) {
- DCHECK(web::GetWebClient());
- web::GetWebClient()->PreWebViewCreation();
-
- UIWebView* result =
- [[CRWStaticFileWebView alloc] initWithFrame:frame
- browserState:browser_state];
-
- web::GetWebClient()->PostWebViewCreation(result);
- return result;
-}
-
-UIWebView* CreateStaticFileWebView() {
- return CreateStaticFileWebView(CGRectZero, nullptr);
-}
-
#if !defined(NDEBUG)
bool IsWebViewAllocInitAllowed() {
static dispatch_once_t once_token = 0;

Powered by Google App Engine
This is Rietveld 408576698