Removing StaticFileWebView vending methods.

Removing StaticFileWebView vending methods.

Not needed anymore.

Moved one existing caller crw_url_verifying_protocol_handler
to instead use a plain UIWebView.

Also, removed the web_view_type param from
CreateSimpleWebViewController

BUG=579697
Committed: https://crrev.com/02ac5385f91ba8d9c369b1d3e0292a5841354fe4
Cr-Commit-Position: refs/heads/master@{#381319}

[shreyasv1, 2016-03-14 20:17:58]

Description was changed from

==========
Removing StaticFileWebView vending methods.

Not needed anymore.

Also, removed the web_view_type param from a related API.

BUG=579697
==========

to

==========
Removing StaticFileWebView vending methods.

Not needed anymore.

Also, removed the web_view_type param from  
CreateSimpleWebViewController

BUG=579697
==========

[shreyasv1, 2016-03-14 20:18:26]

shreyasv@chromium.org changed reviewers:
+ eugenebut@chromium.org

[shreyasv1, 2016-03-14 20:18:27]

I'll follow up by removing CRWStaticFileWebView.

[shreyasv1, 2016-03-14 20:19:08]

Description was changed from

==========
Removing StaticFileWebView vending methods.

Not needed anymore.

Also, removed the web_view_type param from  
CreateSimpleWebViewController

BUG=579697
==========

to

==========
Removing StaticFileWebView vending methods.

Not needed anymore.

Moved one existing caller crw_url_verifying_protocol_handler
to instead use a plain UIWebView.

Also, removed the web_view_type param from  
CreateSimpleWebViewController

BUG=579697
==========

[Eugene But (OOO till 7-30), 2016-03-14 20:25:46]

lgtm with questions (possibly changes).

https://codereview.chromium.org/1799843002/diff/1/ios/web/web_state/web_view_...
File ios/web/web_state/web_view_internal_creation_util.h (right):

https://codereview.chromium.org/1799843002/diff/1/ios/web/web_state/web_view_...
ios/web/web_state/web_view_internal_creation_util.h:10: #include
"ios/web/public/web_view_type.h"
Is this include still necessary?

https://codereview.chromium.org/1799843002/diff/1/ios/web/web_state/web_view_...
File ios/web/web_state/web_view_internal_creation_util.mm (right):

https://codereview.chromium.org/1799843002/diff/1/ios/web/web_state/web_view_...
ios/web/web_state/web_view_internal_creation_util.mm:22: #import
"ios/web/web_state/ui/crw_static_file_web_view.h"
Is this include still necessary?

[shreyasv1, 2016-03-14 22:28:32]

I had to change a few more existing clients of 
CreateSimpleWebViewController.
PTAL.

https://codereview.chromium.org/1799843002/diff/1/ios/web/web_state/web_view_...
File ios/web/web_state/web_view_internal_creation_util.h (right):

https://codereview.chromium.org/1799843002/diff/1/ios/web/web_state/web_view_...
ios/web/web_state/web_view_internal_creation_util.h:10: #include
"ios/web/public/web_view_type.h"
On 2016/03/14 20:25:46, eugenebut wrote:
> Is this include still necessary?

Done.

https://codereview.chromium.org/1799843002/diff/1/ios/web/web_state/web_view_...
File ios/web/web_state/web_view_internal_creation_util.mm (right):

https://codereview.chromium.org/1799843002/diff/1/ios/web/web_state/web_view_...
ios/web/web_state/web_view_internal_creation_util.mm:22: #import
"ios/web/web_state/ui/crw_static_file_web_view.h"
On 2016/03/14 20:25:46, eugenebut wrote:
> Is this include still necessary?

Done.

[Eugene But (OOO till 7-30), 2016-03-14 22:52:45]

still lgtm with a question (and possibly a change)

https://codereview.chromium.org/1799843002/diff/20001/ios/web/web_state/web_v...
File ios/web/web_state/web_view_internal_creation_util.mm (right):

https://codereview.chromium.org/1799843002/diff/20001/ios/web/web_state/web_v...
ios/web/web_state/web_view_internal_creation_util.mm:22: #import
"ios/web/web_state/ui/crw_ui_simple_web_view_controller.h"
Do you still need this include?

[shreyasv1, 2016-03-14 22:54:16]

https://codereview.chromium.org/1799843002/diff/20001/ios/web/web_state/web_v...
File ios/web/web_state/web_view_internal_creation_util.mm (right):

https://codereview.chromium.org/1799843002/diff/20001/ios/web/web_state/web_v...
ios/web/web_state/web_view_internal_creation_util.mm:22: #import
"ios/web/web_state/ui/crw_ui_simple_web_view_controller.h"
On 2016/03/14 22:52:45, eugenebut wrote:
> Do you still need this include?

Good catch. Done.

[shreyasv1, 2016-03-14 22:54:32]

The CQ bit was checked by shreyasv@chromium.org

[shreyasv1, 2016-03-14 22:54:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/1799843002/#ps40001
(title: "y")

[commit-bot: I haz the power, 2016-03-14 22:55:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1799843002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1799843002/40001

[commit-bot: I haz the power, 2016-03-14 23:18:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-14 23:18:17]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[shreyasv1, 2016-03-15 20:06:47]

The CQ bit was checked by shreyasv@chromium.org

[shreyasv1, 2016-03-15 20:06:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/1799843002/#ps60001
(title: "GetBS()")

[commit-bot: I haz the power, 2016-03-15 20:07:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1799843002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1799843002/60001

[commit-bot: I haz the power, 2016-03-15 21:29:39]

Description was changed from

==========
Removing StaticFileWebView vending methods.

Not needed anymore.

Moved one existing caller crw_url_verifying_protocol_handler
to instead use a plain UIWebView.

Also, removed the web_view_type param from  
CreateSimpleWebViewController

BUG=579697
==========

to

==========
Removing StaticFileWebView vending methods.

Not needed anymore.

Moved one existing caller crw_url_verifying_protocol_handler
to instead use a plain UIWebView.

Also, removed the web_view_type param from  
CreateSimpleWebViewController

BUG=579697
==========

[commit-bot: I haz the power, 2016-03-15 21:29:40]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-15 21:30:42]

Description was changed from

==========
Removing StaticFileWebView vending methods.

Not needed anymore.

Moved one existing caller crw_url_verifying_protocol_handler
to instead use a plain UIWebView.

Also, removed the web_view_type param from  
CreateSimpleWebViewController

BUG=579697
==========

to

==========
Removing StaticFileWebView vending methods.

Not needed anymore.

Moved one existing caller crw_url_verifying_protocol_handler
to instead use a plain UIWebView.

Also, removed the web_view_type param from
CreateSimpleWebViewController

BUG=579697

Committed: https://crrev.com/02ac5385f91ba8d9c369b1d3e0292a5841354fe4
Cr-Commit-Position: refs/heads/master@{#381319}
==========

[commit-bot: I haz the power, 2016-03-15 21:30:43]

Patchset 4 (id:??) landed as
https://crrev.com/02ac5385f91ba8d9c369b1d3e0292a5841354fe4
Cr-Commit-Position: refs/heads/master@{#381319}