Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: ios/web/web_state/web_view_internal_creation_util_unittest.mm

Issue 1799843002: Removing StaticFileWebView vending methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: GetBS() Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/web_state/web_view_internal_creation_util.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/web_view_internal_creation_util_unittest.mm
diff --git a/ios/web/web_state/web_view_internal_creation_util_unittest.mm b/ios/web/web_state/web_view_internal_creation_util_unittest.mm
index 6696286124d2d31b743636617c90ba124b0ba7eb..6616a28d652426b3f8efefbb90bec91682710ccc 100644
--- a/ios/web/web_state/web_view_internal_creation_util_unittest.mm
+++ b/ios/web/web_state/web_view_internal_creation_util_unittest.mm
@@ -182,29 +182,12 @@ TEST_F(WebViewCreationUtilsTest, GetActiveWKWebViewsCount) {
#endif // defined(NDEBUG)
-// Tests web::CreateStaticFileWebView that it correctly returns a
-// CRWStaticFileWebView with the correct frame, user agent, and calls
-// WebClient::PreWebViewCreation/WebClient::PostWebViewCreation methods.
-TEST_F(WebViewCreationUtilsTest, TestNewStaticFileWebViewTrue) {
- UIWebView* captured_web_view = nil;
- ExpectWebClientCalls(&captured_web_view);
-
- base::scoped_nsobject<UIWebView> web_view(
- CreateStaticFileWebView(kTestFrame, GetBrowserState()));
- ASSERT_TRUE([web_view isMemberOfClass:[CRWStaticFileWebView class]]);
- EXPECT_TRUE(CGRectEqualToRect(kTestFrame, [web_view frame]));
- EXPECT_NSEQ(web_view, captured_web_view);
-
- NSString* user_agent = GetWebViewUserAgent(web_view);
- EXPECT_TRUE([CRWStaticFileWebView isStaticFileUserAgent:user_agent]);
-}
-
// Tests web::CreateSimpleWebViewController returns a CRWSimpleWebViewController
// instance with a web view.
TEST_F(WebViewCreationUtilsTest, CreateSimpleWebViewController) {
base::scoped_nsprotocol<id<CRWSimpleWebViewController>>
simpleWebViewController(
- CreateSimpleWebViewController(CGRectZero, nullptr, UI_WEB_VIEW_TYPE));
+ CreateSimpleWebViewController(CGRectZero, GetBrowserState()));
EXPECT_TRUE([simpleWebViewController view]);
}
« no previous file with comments | « ios/web/web_state/web_view_internal_creation_util.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698