gpu_host_messages.h => content/gpu

gpu_host_messages.h => content/gpu

gpu_host_messages consists of host <=> gpu IPC messages and
is browser specific.

Thus, for the time being, it makes sense to keep this file
in content.

The rest of content/common/gpu is moving to gpu/ipc. Thus,
we are moving gpu_host_messages to content/gpu.

GpuHostMsg_EstablishGpuChannel, and
GpuHostMsg_HasGpuProcess didn't fit in with the rest of
gpu_host_messages because they are renderer => browser
messages. Thus this CL also moves those oddball IPCs to
child_process_messsages.h.

Some traits are used by both child_process_messages and
gpu_host_messages. I've moved those traits to
content/common/gpu/gpu_param_traits_macros.h.

BUG=586365
Committed: https://crrev.com/68efb4803bf77935194d31ca1d93e639282cd7b5
Cr-Commit-Position: refs/heads/master@{#381693}

[Fady Samuel, 2016-03-16 16:50:25]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-16 16:50:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1799713002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1799713002/40001

[commit-bot: I haz the power, 2016-03-16 17:00:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 17:00:50]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-03-16 17:41:09]

Description was changed from

==========
[Work in progress] gpu_host_messages.h => content/gpu

BUG=
==========

to

==========
[Work in progress] gpu_host_messages.h => content/gpu

gpu_host_messages consists of host <=> gpu IPC messages and 
is browser specific.

Thus, for the time being, it makes sense to keep this file
in content.

The rest of content/common/gpu is moving to gpu/ipc. Thus, we are moving
gpu_host_messages to content/gpu.

GpuHostMsg_EstablishGpuChannel, and GpuHostMsg_HasGpuProcess didn't fit in with
the rest of gpu_host_messages because they are renderer => browser messages.
Thus this CL also moves those oddball IPCs to 
child_process_messsages.h.

Some traits are used by both child_process_messages and 
gpu_host_messages. I've moved those traits to
content/common/gpu/gpu_param_traits_macros.h.

BUG=
==========

[Fady Samuel, 2016-03-16 17:42:49]

Description was changed from

==========
[Work in progress] gpu_host_messages.h => content/gpu

gpu_host_messages consists of host <=> gpu IPC messages and 
is browser specific.

Thus, for the time being, it makes sense to keep this file
in content.

The rest of content/common/gpu is moving to gpu/ipc. Thus, we are moving
gpu_host_messages to content/gpu.

GpuHostMsg_EstablishGpuChannel, and GpuHostMsg_HasGpuProcess didn't fit in with
the rest of gpu_host_messages because they are renderer => browser messages.
Thus this CL also moves those oddball IPCs to 
child_process_messsages.h.

Some traits are used by both child_process_messages and 
gpu_host_messages. I've moved those traits to
content/common/gpu/gpu_param_traits_macros.h.

BUG=
==========

to

==========
[Work in progress] gpu_host_messages.h => content/gpu

gpu_host_messages consists of host <=> gpu IPC messages and 
is browser specific.

Thus, for the time being, it makes sense to keep this file
in content.

The rest of content/common/gpu is moving to gpu/ipc. Thus, we are moving
gpu_host_messages to content/gpu.

GpuHostMsg_EstablishGpuChannel, and GpuHostMsg_HasGpuProcess didn't fit in with
the rest of 
gpu_host_messages because they are renderer => browser 
messages. Thus this CL also moves those oddball IPCs to 
child_process_messsages.h.

Some traits are used by both child_process_messages and 
gpu_host_messages. I've moved those traits to 
content/common/gpu/gpu_param_traits_macros.h.

BUG=
==========

[Fady Samuel, 2016-03-16 17:43:07]

Description was changed from

==========
[Work in progress] gpu_host_messages.h => content/gpu

gpu_host_messages consists of host <=> gpu IPC messages and 
is browser specific.

Thus, for the time being, it makes sense to keep this file
in content.

The rest of content/common/gpu is moving to gpu/ipc. Thus, we are moving
gpu_host_messages to content/gpu.

GpuHostMsg_EstablishGpuChannel, and GpuHostMsg_HasGpuProcess didn't fit in with
the rest of 
gpu_host_messages because they are renderer => browser 
messages. Thus this CL also moves those oddball IPCs to 
child_process_messsages.h.

Some traits are used by both child_process_messages and 
gpu_host_messages. I've moved those traits to 
content/common/gpu/gpu_param_traits_macros.h.

BUG=
==========

to

==========
[Work in progress] gpu_host_messages.h => content/gpu

gpu_host_messages consists of host <=> gpu IPC messages and 
is browser specific.

Thus, for the time being, it makes sense to keep this file
in content.

The rest of content/common/gpu is moving to gpu/ipc. Thus, 
we are moving gpu_host_messages to content/gpu.

GpuHostMsg_EstablishGpuChannel, and GpuHostMsg_HasGpuProcess didn't fit in with
the rest of 
gpu_host_messages because they are renderer => browser 
messages. Thus this CL also moves those oddball IPCs to 
child_process_messsages.h.

Some traits are used by both child_process_messages and 
gpu_host_messages. I've moved those traits to 
content/common/gpu/gpu_param_traits_macros.h.

BUG=
==========

[Fady Samuel, 2016-03-16 17:43:19]

Description was changed from

==========
[Work in progress] gpu_host_messages.h => content/gpu

gpu_host_messages consists of host <=> gpu IPC messages and 
is browser specific.

Thus, for the time being, it makes sense to keep this file
in content.

The rest of content/common/gpu is moving to gpu/ipc. Thus, 
we are moving gpu_host_messages to content/gpu.

GpuHostMsg_EstablishGpuChannel, and GpuHostMsg_HasGpuProcess didn't fit in with
the rest of 
gpu_host_messages because they are renderer => browser 
messages. Thus this CL also moves those oddball IPCs to 
child_process_messsages.h.

Some traits are used by both child_process_messages and 
gpu_host_messages. I've moved those traits to 
content/common/gpu/gpu_param_traits_macros.h.

BUG=
==========

to

==========
[Work in progress] gpu_host_messages.h => content/gpu

gpu_host_messages consists of host <=> gpu IPC messages and 
is browser specific.

Thus, for the time being, it makes sense to keep this file
in content.

The rest of content/common/gpu is moving to gpu/ipc. Thus, 
we are moving gpu_host_messages to content/gpu.

GpuHostMsg_EstablishGpuChannel, and 
GpuHostMsg_HasGpuProcess didn't fit in with the rest of 
gpu_host_messages because they are renderer => browser 
messages. Thus this CL also moves those oddball IPCs to 
child_process_messsages.h.

Some traits are used by both child_process_messages and 
gpu_host_messages. I've moved those traits to 
content/common/gpu/gpu_param_traits_macros.h.

BUG=
==========

[Fady Samuel, 2016-03-16 17:43:29]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-16 17:43:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1799713002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1799713002/60001

[Fady Samuel, 2016-03-16 17:44:12]

Description was changed from

==========
[Work in progress] gpu_host_messages.h => content/gpu

gpu_host_messages consists of host <=> gpu IPC messages and 
is browser specific.

Thus, for the time being, it makes sense to keep this file
in content.

The rest of content/common/gpu is moving to gpu/ipc. Thus, 
we are moving gpu_host_messages to content/gpu.

GpuHostMsg_EstablishGpuChannel, and 
GpuHostMsg_HasGpuProcess didn't fit in with the rest of 
gpu_host_messages because they are renderer => browser 
messages. Thus this CL also moves those oddball IPCs to 
child_process_messsages.h.

Some traits are used by both child_process_messages and 
gpu_host_messages. I've moved those traits to 
content/common/gpu/gpu_param_traits_macros.h.

BUG=
==========

to

==========
gpu_host_messages.h => content/gpu

gpu_host_messages consists of host <=> gpu IPC messages and 
is browser specific.

Thus, for the time being, it makes sense to keep this file
in content.

The rest of content/common/gpu is moving to gpu/ipc. Thus, 
we are moving gpu_host_messages to content/gpu.

GpuHostMsg_EstablishGpuChannel, and 
GpuHostMsg_HasGpuProcess didn't fit in with the rest of 
gpu_host_messages because they are renderer => browser 
messages. Thus this CL also moves those oddball IPCs to 
child_process_messsages.h.

Some traits are used by both child_process_messages and 
gpu_host_messages. I've moved those traits to 
content/common/gpu/gpu_param_traits_macros.h.

BUG=586365
==========

[Fady Samuel, 2016-03-16 17:55:58]

fsamuel@chromium.org changed reviewers:
+ piman@chromium.org

[Fady Samuel, 2016-03-16 17:55:59]

Hi Antoine,

How do you feel about this refactor? Thanks!

Fady

[commit-bot: I haz the power, 2016-03-16 17:57:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 17:57:48]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Fady Samuel, 2016-03-16 20:40:37]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-16 20:41:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1799713002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1799713002/80001

[commit-bot: I haz the power, 2016-03-16 20:59:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 20:59:57]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-03-16 21:10:03]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-16 21:10:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1799713002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1799713002/100001

[commit-bot: I haz the power, 2016-03-16 21:22:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 21:22:29]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-03-16 22:09:36]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-16 22:10:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1799713002/70037
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1799713002/70037

[commit-bot: I haz the power, 2016-03-16 22:22:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 22:22:58]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[piman, 2016-03-17 00:15:09]

lgtm

[Fady Samuel, 2016-03-17 00:18:02]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2016-03-17 00:18:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1799713002/70037
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1799713002/70037

[commit-bot: I haz the power, 2016-03-17 00:30:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 00:30:10]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-03-17 00:49:16]

fsamuel@chromium.org changed reviewers:
+ dcheng@chromium.org

[Fady Samuel, 2016-03-17 00:49:17]

+dcheng@ for messages

[Fady Samuel, 2016-03-17 02:37:36]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-17 02:37:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1799713002/130001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1799713002/130001

[commit-bot: I haz the power, 2016-03-17 03:37:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 03:37:08]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-03-17 07:48:43]

lgtm

[Fady Samuel, 2016-03-17 12:10:15]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-03-17 12:10:15]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1799713002/#ps130001
(title: "Removed an unnecessary include")

[commit-bot: I haz the power, 2016-03-17 12:10:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1799713002/130001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1799713002/130001

[commit-bot: I haz the power, 2016-03-17 12:15:51]

Description was changed from

==========
gpu_host_messages.h => content/gpu

gpu_host_messages consists of host <=> gpu IPC messages and 
is browser specific.

Thus, for the time being, it makes sense to keep this file
in content.

The rest of content/common/gpu is moving to gpu/ipc. Thus, 
we are moving gpu_host_messages to content/gpu.

GpuHostMsg_EstablishGpuChannel, and 
GpuHostMsg_HasGpuProcess didn't fit in with the rest of 
gpu_host_messages because they are renderer => browser 
messages. Thus this CL also moves those oddball IPCs to 
child_process_messsages.h.

Some traits are used by both child_process_messages and 
gpu_host_messages. I've moved those traits to 
content/common/gpu/gpu_param_traits_macros.h.

BUG=586365
==========

to

==========
gpu_host_messages.h => content/gpu

gpu_host_messages consists of host <=> gpu IPC messages and 
is browser specific.

Thus, for the time being, it makes sense to keep this file
in content.

The rest of content/common/gpu is moving to gpu/ipc. Thus, 
we are moving gpu_host_messages to content/gpu.

GpuHostMsg_EstablishGpuChannel, and 
GpuHostMsg_HasGpuProcess didn't fit in with the rest of 
gpu_host_messages because they are renderer => browser 
messages. Thus this CL also moves those oddball IPCs to 
child_process_messsages.h.

Some traits are used by both child_process_messages and 
gpu_host_messages. I've moved those traits to 
content/common/gpu/gpu_param_traits_macros.h.

BUG=586365
==========

[commit-bot: I haz the power, 2016-03-17 12:15:53]

Committed patchset #8 (id:130001)

[commit-bot: I haz the power, 2016-03-17 12:17:32]

Description was changed from

==========
gpu_host_messages.h => content/gpu

gpu_host_messages consists of host <=> gpu IPC messages and 
is browser specific.

Thus, for the time being, it makes sense to keep this file
in content.

The rest of content/common/gpu is moving to gpu/ipc. Thus, 
we are moving gpu_host_messages to content/gpu.

GpuHostMsg_EstablishGpuChannel, and 
GpuHostMsg_HasGpuProcess didn't fit in with the rest of 
gpu_host_messages because they are renderer => browser 
messages. Thus this CL also moves those oddball IPCs to 
child_process_messsages.h.

Some traits are used by both child_process_messages and 
gpu_host_messages. I've moved those traits to 
content/common/gpu/gpu_param_traits_macros.h.

BUG=586365
==========

to

==========
gpu_host_messages.h => content/gpu

gpu_host_messages consists of host <=> gpu IPC messages and
is browser specific.

Thus, for the time being, it makes sense to keep this file
in content.

The rest of content/common/gpu is moving to gpu/ipc. Thus,
we are moving gpu_host_messages to content/gpu.

GpuHostMsg_EstablishGpuChannel, and
GpuHostMsg_HasGpuProcess didn't fit in with the rest of
gpu_host_messages because they are renderer => browser
messages. Thus this CL also moves those oddball IPCs to
child_process_messsages.h.

Some traits are used by both child_process_messages and
gpu_host_messages. I've moved those traits to
content/common/gpu/gpu_param_traits_macros.h.

BUG=586365

Committed: https://crrev.com/68efb4803bf77935194d31ca1d93e639282cd7b5
Cr-Commit-Position: refs/heads/master@{#381693}
==========

[commit-bot: I haz the power, 2016-03-17 12:17:33]

Patchset 8 (id:??) landed as
https://crrev.com/68efb4803bf77935194d31ca1d93e639282cd7b5
Cr-Commit-Position: refs/heads/master@{#381693}

[jam, 2016-03-22 16:50:47]

jam@chromium.org changed reviewers:
+ jam@chromium.org

[jam, 2016-03-22 16:50:48]

https://codereview.chromium.org/1799713002/diff/130001/content/browser/DEPS
File content/browser/DEPS (right):

https://codereview.chromium.org/1799713002/diff/130001/content/browser/DEPS#n...
content/browser/DEPS:14: "+content/gpu",
this is incorrect. content/browser should not depend on content/gpu.

for one thing, it brings in code from blink into the browser process through all
the dependencies.

if code is shared with the browser and gpu processes, it should be in
content/common. but we can't include content/gpu here, just like we can't
include content/renderer

[brettw, 2016-03-22 16:56:06]

This is wrong.

GPU is a "child" process and links with content/child which in turn links Blink.
This patch makes content/browser use content/gpu which brings in content/child
and everything else.

Communications between these process types should be in "common" (sharing
between these is what it's there for). If you don't want to have
content/common/gpu, you can just put it in the toplevel content/common.

Please fix soon, I'm trying to get this stuff to pass "gn check" to prevent
further regressions. I filed
https://bugs.chromium.org/p/chromium/issues/detail?id=596935

[Fady Samuel, 2016-03-22 16:56:24]

On 2016/03/22 16:50:48, jam wrote:
> https://codereview.chromium.org/1799713002/diff/130001/content/browser/DEPS
> File content/browser/DEPS (right):
> 
>
https://codereview.chromium.org/1799713002/diff/130001/content/browser/DEPS#n...
> content/browser/DEPS:14: "+content/gpu",
> this is incorrect. content/browser should not depend on content/gpu.
> 
> for one thing, it brings in code from blink into the browser process through
all
> the dependencies.
> 
> if code is shared with the browser and gpu processes, it should be in
> content/common. but we can't include content/gpu here, just like we can't
> include content/renderer

Hmm, so the problem here is we're trying to separate browser<=>gpu code in
content/gpu from client<=>gpu code in content/common/gpu.

How about a content/gpu/common? :P

[jam, 2016-03-22 17:02:22]

On 2016/03/22 16:56:24, Fady Samuel wrote:
> On 2016/03/22 16:50:48, jam wrote:
> > https://codereview.chromium.org/1799713002/diff/130001/content/browser/DEPS
> > File content/browser/DEPS (right):
> > 
> >
>
https://codereview.chromium.org/1799713002/diff/130001/content/browser/DEPS#n...
> > content/browser/DEPS:14: "+content/gpu",
> > this is incorrect. content/browser should not depend on content/gpu.
> > 
> > for one thing, it brings in code from blink into the browser process through
> all
> > the dependencies.
> > 
> > if code is shared with the browser and gpu processes, it should be in
> > content/common. but we can't include content/gpu here, just like we can't
> > include content/renderer
> 
> Hmm, so the problem here is we're trying to separate browser<=>gpu code in
> content/gpu from client<=>gpu code in content/common/gpu.
> 
> How about a content/gpu/common? :P

content/gpu would still not be the place to put shared code. it has to be under
content/common somewhere. you can rename the subdirs of content/common to be
whatever you think clearly identifies this (i.e. content/common/browser_gpu and
content/common/child_gpu).