[Findit] Collect failed output nodes of compile and link failures by strict regex

appengine/findit/waterfall/try_job_util.py

Index: appengine/findit/waterfall/try_job_util.py
diff --git a/appengine/findit/waterfall/try_job_util.py b/appengine/findit/waterfall/try_job_util.py
index 738c9f197b04544868ed28dd02e2cb56a7c1eeea..fa85d248802aa47eef641437d2cf8708c2af4be0 100644
--- a/appengine/findit/waterfall/try_job_util.py
+++ b/appengine/findit/waterfall/try_job_util.py
@@ -117,18 +117,24 @@ def _NeedANewTryJob(
   return need_new_try_job, last_pass, try_job_type, targeted_tests
 
 
-def _GetFailedTargetsFromSignals(signals):
+def _GetFailedTargetsFromSignals(signals, master_name, builder_name):
   compile_targets = []
 
   if not signals or 'compile' not in signals:
     return compile_targets
 
+  strict_regex = waterfall_config.EnableStrictRegexForCompileLinkFailures(
+      master_name, builder_name)
   for source_target in signals['compile']['failed_targets']:
     # Link failures have only targets but no source. TODO(lijeffrey):
     # Currently only link failures on linux are supported. Add support for
     # compile failures and other platforms as well.
     if not source_target.get('source'):

[lijeffrey, 2016/03/15 07:12:26]

nit: I think this if can be simplified to

if not source_target.get('source') or strict_regex:
  compile_targets.append(source_target.get('target'))

[stgao, 2016/03/15 18:32:21]

sg. Done.

       compile_targets.append(source_target.get('target'))
+    elif strict_regex:
+      # Use object files as the compile targets on bots that we use strict
+      # regex to extract such information.
+      compile_targets.append(source_target.get('target'))
 
   return compile_targets
 
@@ -156,7 +162,8 @@ def ScheduleTryJobIfNeeded(failure_info, signals=None, build_completed=False):
                       failed_steps, failure_result_map))
 
   if need_new_try_job:
-    compile_targets = (_GetFailedTargetsFromSignals(signals)
+    compile_targets = (_GetFailedTargetsFromSignals(
+        signals, master_name, builder_name)
                        if try_job_type == TryJobType.COMPILE else None)
 
     pipeline = (