Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1799183002: [ChromeDriver] Add nested frame xpath expression in order to switch to frame present inside nested … (Closed)

Created:
4 years, 9 months ago by gmanikpure
Modified:
4 years, 9 months ago
Reviewers:
samuong
CC:
chromium-reviews, samuong+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ChromeDriver] Add nested frame xpath expression in order to switch to frame present inside nested frameset. BUG=chromedriver:107 Committed: https://crrev.com/ac97d6e132d31817f3cfa70e815d500cf76f8a58 Cr-Commit-Position: refs/heads/master@{#381753}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
M chrome/test/chromedriver/test/run_py_tests.py View 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/window_commands.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome/test/data/chromedriver/nested_frameset.html View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
gmanikpure
Hi Sam, This CL contains fix for Issue107 (& duplicated issues 1330, 888 having different ...
4 years, 9 months ago (2016-03-14 18:37:31 UTC) #2
samuong
lgtm as long as the presubmit passes without issue, thanks!
4 years, 9 months ago (2016-03-14 19:50:26 UTC) #3
gmanikpure
On 2016/03/14 19:50:26, samuong wrote: > lgtm as long as the presubmit passes without issue, ...
4 years, 9 months ago (2016-03-17 16:44:10 UTC) #4
samuong
that's great news, still lgtm
4 years, 9 months ago (2016-03-17 17:04:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1799183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1799183002/1
4 years, 9 months ago (2016-03-17 17:17:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 18:30:49 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 18:32:15 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac97d6e132d31817f3cfa70e815d500cf76f8a58
Cr-Commit-Position: refs/heads/master@{#381753}

Powered by Google App Engine
This is Rietveld 408576698