chrome/test/chromedriver/window_commands.cc - Issue 1799183002: [ChromeDriver] Add nested frame xpath expression in order to switch to frame present inside nested …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/window_commands.cc

Issue 1799183002: [ChromeDriver] Add nested frame xpath expression in order to switch to frame present inside nested … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/chromedriver/window_commands.cc

diff --git a/chrome/test/chromedriver/window_commands.cc b/chrome/test/chromedriver/window_commands.cc

index ff0be7fa2c2e8505d49f6d99f16f715a51593886..4a45b2bae4a66da39070efbdebb2de9e915b5974 100644

--- a/chrome/test/chromedriver/window_commands.cc

+++ b/chrome/test/chromedriver/window_commands.cc

@@ -347,7 +347,7 @@ Status ExecuteSwitchToFrame(

" return document.evaluate(xpath, document, null, "

" XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue;"

"}";

- std::string xpath = "(/html/body//iframe|/html/frameset/frame)";

+ std::string xpath = "(/html/body//iframe|/html/frameset//frame)";

std::string id_string;

int id_int;

if (id->GetAsString(&id_string)) {

« no previous file with comments | « chrome/test/chromedriver/test/run_py_tests.py ('k') | chrome/test/data/chromedriver/nested_frameset.html » ('j') | no next file with comments »