Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: chrome/tools/build/win/create_installer_archive.py

Issue 179903004: Always embed manifests, even in component builds! (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: don't change .bat file in this CL -- CQ no likee Batch Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/setup/install_worker.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/tools/build/win/create_installer_archive.py
diff --git a/chrome/tools/build/win/create_installer_archive.py b/chrome/tools/build/win/create_installer_archive.py
index f4ebd5b7a52313cecd6bd410a7628e4697930530..8b2331f627e642653af5b7532bffeefea467311d 100755
--- a/chrome/tools/build/win/create_installer_archive.py
+++ b/chrome/tools/build/win/create_installer_archive.py
@@ -468,15 +468,6 @@ def DoComponentBuildTasks(staging_dir, build_dir, target_arch, current_version):
shutil.copy(component_dll, installer_dir)
component_dll_filenames.append(os.path.basename(component_dll))
- # Copy chrome.exe.manifest as-is. It is required, among other things, to
- # declare a dependency on the version dir assembly.
- shutil.copy(os.path.join(build_dir, 'chrome.exe.manifest'), chrome_dir)
-
- # Also copy setup.exe.manifest as-is. It is required, among other things, to
- # let setup.exe UAC when it wants to, by specifying that it handles elevation
- # "asInvoker", rather than have Windows auto-elevate it when launched.
- shutil.copy(os.path.join(build_dir, 'setup.exe.manifest'), installer_dir)
-
# Augment {version}.manifest to include all component DLLs as part of the
# assembly it constitutes, which will allow dependents of this assembly to
# find these DLLs.
« no previous file with comments | « chrome/installer/setup/install_worker.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698