Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5779)

Unified Diff: chrome/installer/setup/install_worker.cc

Issue 179903004: Always embed manifests, even in component builds! (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: don't change .bat file in this CL -- CQ no likee Batch Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | chrome/tools/build/win/create_installer_archive.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/install_worker.cc
diff --git a/chrome/installer/setup/install_worker.cc b/chrome/installer/setup/install_worker.cc
index 1713fe5884a2077c9cf9376eba5bce734372bab2..991ef799d8bd4beb99b470159f799909ca4fb0e4 100644
--- a/chrome/installer/setup/install_worker.cc
+++ b/chrome/installer/setup/install_worker.cc
@@ -500,19 +500,6 @@ void AddChromeWorkItems(const InstallationState& original_state,
temp_path);
}
- // For the component build to work with the installer, we need to also drop
- // chrome.exe.manifest (other manifests are already contained in the version
- // directory in the archive so no explicit work is required for them).
-#if defined(COMPONENT_BUILD)
- static const base::FilePath::CharType kChromeExeManifest[] =
- FILE_PATH_LITERAL("chrome.exe.manifest");
- install_list->AddMoveTreeWorkItem(
- src_path.Append(kChromeExeManifest).value(),
- target_path.Append(kChromeExeManifest).value(),
- temp_path.value(),
- WorkItem::ALWAYS_MOVE);
-#endif // defined(COMPONENT_BUILD)
-
// In the past, we copied rather than moved for system level installs so that
// the permissions of %ProgramFiles% would be picked up. Now that |temp_path|
// is in %ProgramFiles% for system level installs (and in %LOCALAPPDATA%
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | chrome/tools/build/win/create_installer_archive.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698