Retire transformTypesMatch from SVGTransformListInterpolationType.cpp

Retire transformTypesMatch from SVGTransformListInterpolationType.cpp

The code is simpler without this extra method.

Committed: https://crrev.com/82bfceea6a6ae11814eca6427efd5c517f59ab2c
Cr-Commit-Position: refs/heads/master@{#404604}

[Eric Willigers, 2016-03-14 03:12:35]

ericwilligers@chromium.org changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2016-03-14 03:14:54]

https://codereview.chromium.org/1798743002/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.cpp
(right):

https://codereview.chromium.org/1798743002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.cpp:276:
const Vector<SVGTransformType>& endTransformTypes =
toSVGTransformNonInterpolableValue(*end.nonInterpolableValue).transformTypes();
Why not continue using getTransformTypes()? It could be inlined directly into
the condition to avoid these lengthy local variables.

[Eric Willigers, 2016-07-11 04:32:35]

Description was changed from

==========
Retire transformTypesMatch from SVGTransformListInterpolationType.cpp

start and end are passed into mergeSingleConversions by rvalue
reference. We were then passing them on to transformTypesMatch by
reference.
==========

to

==========
Retire transformTypesMatch from SVGTransformListInterpolationType.cpp

The code is simpler without this extra method.
==========

[Eric Willigers, 2016-07-11 04:33:06]

https://codereview.chromium.org/1798743002/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.cpp
(right):

https://codereview.chromium.org/1798743002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.cpp:276:
const Vector<SVGTransformType>& endTransformTypes =
toSVGTransformNonInterpolableValue(*end.nonInterpolableValue).transformTypes();
On 2016/03/14 at 03:14:54, alancutter wrote:
> Why not continue using getTransformTypes()? It could be inlined directly into
the condition to avoid these lengthy local variables.

Done

[alancutter (OOO until 2018), 2016-07-11 04:38:24]

lgtm

[Eric Willigers, 2016-07-11 05:04:51]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2016-07-11 05:04:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 06:17:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-11 06:19:36]

Description was changed from

==========
Retire transformTypesMatch from SVGTransformListInterpolationType.cpp

The code is simpler without this extra method.
==========

to

==========
Retire transformTypesMatch from SVGTransformListInterpolationType.cpp

The code is simpler without this extra method.

Committed: https://crrev.com/82bfceea6a6ae11814eca6427efd5c517f59ab2c
Cr-Commit-Position: refs/heads/master@{#404604}
==========

[commit-bot: I haz the power, 2016-07-11 06:19:37]

Patchset 2 (id:??) landed as
https://crrev.com/82bfceea6a6ae11814eca6427efd5c517f59ab2c
Cr-Commit-Position: refs/heads/master@{#404604}