Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.cpp

Issue 1798743002: Retire transformTypesMatch from SVGTransformListInterpolationType.cpp (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: getTransformTypes Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.cpp
diff --git a/third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.cpp b/third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.cpp
index f195fb0bfe4fed8915935f9bc8105ea8227cb95e..ce47d64780513cd80f009aa6aecd81b4ec79586e 100644
--- a/third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.cpp
+++ b/third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.cpp
@@ -175,13 +175,6 @@ const Vector<SVGTransformType>& getTransformTypes(const InterpolationValue& valu
return toSVGTransformNonInterpolableValue(*value.nonInterpolableValue).transformTypes();
}
-bool transformTypesMatch(const InterpolationValue& first, const InterpolationValue& second)
-{
- const Vector<SVGTransformType>& firstTransformTypes = getTransformTypes(first);
- const Vector<SVGTransformType>& secondTransformTypes = getTransformTypes(second);
- return firstTransformTypes == secondTransformTypes;
-}
-
class SVGTransformListChecker : public InterpolationType::ConversionChecker {
public:
static std::unique_ptr<SVGTransformListChecker> create(const InterpolationValue& underlying)
@@ -288,7 +281,7 @@ SVGPropertyBase* SVGTransformListInterpolationType::appliedSVGValue(const Interp
PairwiseInterpolationValue SVGTransformListInterpolationType::maybeMergeSingles(InterpolationValue&& start, InterpolationValue&& end) const
{
- if (!transformTypesMatch(start, end))
+ if (getTransformTypes(start) != getTransformTypes(end))
return nullptr;
return PairwiseInterpolationValue(std::move(start.interpolableValue), std::move(end.interpolableValue), end.nonInterpolableValue.release());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698