Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 179873004: remove support for InputMethodOptions_Open_* which hasn't been used for a while and is now removed. (Closed)

Created:
6 years, 10 months ago by Junichi Uekawa
Modified:
6 years, 9 months ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

remove support for InputMethodOptions_Open_* which hasn't been used for a while and is now removed. R=asvitkine@chromium.org BUG=287730 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255885

Patch Set 1 #

Patch Set 2 : merge actions.xml change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1012 lines, -185 lines) Patch
M tools/metrics/actions/actions.xml View 1 1 chunk +1012 lines, -184 lines 0 comments Download
M tools/metrics/actions/extract_actions.py View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
Junichi Uekawa
6 years, 10 months ago (2014-02-26 09:50:51 UTC) #1
Junichi Uekawa
Hi Alexei, I've removed the logging code path that wasn't doing anything; and now I'd ...
6 years, 9 months ago (2014-03-05 23:59:03 UTC) #2
Alexei Svitkine (slow)
Sorry for not getting back to this sooner. We've recently expanded the infrastructure for actions ...
6 years, 9 months ago (2014-03-06 16:23:23 UTC) #3
Junichi Uekawa
On 2014/03/06 16:23:23, Alexei Svitkine wrote: > Sorry for not getting back to this sooner. ...
6 years, 9 months ago (2014-03-07 02:20:01 UTC) #4
Junichi Uekawa
On 2014/03/07 02:20:01, uekawa wrote: > On 2014/03/06 16:23:23, Alexei Svitkine wrote: > > Sorry ...
6 years, 9 months ago (2014-03-07 04:09:52 UTC) #5
Alexei Svitkine (slow)
On 2014/03/07 04:09:52, uekawa wrote: > On 2014/03/07 02:20:01, uekawa wrote: > > On 2014/03/06 ...
6 years, 9 months ago (2014-03-07 22:36:47 UTC) #6
Junichi Uekawa
On 2014/03/07 22:36:47, Alexei Svitkine wrote: > On 2014/03/07 04:09:52, uekawa wrote: > > On ...
6 years, 9 months ago (2014-03-08 02:03:07 UTC) #7
Alexei Svitkine (slow)
LGTM, thanks for your patience!
6 years, 9 months ago (2014-03-08 03:05:47 UTC) #8
Junichi Uekawa
The CQ bit was checked by uekawa@chromium.org
6 years, 9 months ago (2014-03-08 05:50:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/uekawa@chromium.org/179873004/20001
6 years, 9 months ago (2014-03-08 11:14:25 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 12:41:04 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=278165
6 years, 9 months ago (2014-03-08 12:41:05 UTC) #12
Junichi Uekawa
The CQ bit was checked by uekawa@chromium.org
6 years, 9 months ago (2014-03-09 22:31:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/uekawa@chromium.org/179873004/20001
6 years, 9 months ago (2014-03-09 22:31:20 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 06:30:54 UTC) #15
Message was sent while issue was closed.
Change committed as 255885

Powered by Google App Engine
This is Rietveld 408576698