Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 1798263002: Rename isTreatedAsOrStackingContext to isStacked (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Markdown, isStacked, paintAllPhasesAtomically Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
index d862aeb1dc14389067679e89239e7487a9450612..7a80368e25b3c0aa554df317a7e41727ee68a28f 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
@@ -296,10 +296,10 @@ void LayoutBoxModelObject::styleDidChange(StyleDifference diff, const ComputedSt
void LayoutBoxModelObject::createLayer(PaintLayerType type)
{
// If the current paint invalidation container is not a stacking context and this object is
- // a or treated as a stacking context, creating this layer may cause this object and its
+ // a stacked content, creating this layer may cause this object and its
pdr. 2016/03/16 02:22:53 Nit: "... and this object is stacked content, ..."
Xianzhu 2016/03/16 18:10:24 Done.
// descendants to change paint invalidation container. Therefore we must eagerly invalidate
// them on the original paint invalidation container before creating the layer.
- if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled() && isRooted() && styleRef().isTreatedAsOrStackingContext()) {
+ if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled() && isRooted() && PaintLayerStackingNode::shouldStackObject(*this)) {
const LayoutBoxModelObject& currentPaintInvalidationContainer = containerForPaintInvalidation();
if (!currentPaintInvalidationContainer.styleRef().isStackingContext())
invalidatePaintIncludingNonSelfPaintingLayerDescendants(currentPaintInvalidationContainer);

Powered by Google App Engine
This is Rietveld 408576698