Stop scheduling in-order script execution upon hitting failed script.

Stop scheduling in-order script execution upon hitting failed script.

R=haraken
BUG=581425
Committed: https://crrev.com/10cb02165d6d68a66007a3522f23a89fcb8a69d5
Cr-Commit-Position: refs/heads/master@{#381217}

Committed: https://crrev.com/fde6c7118d13dbe3e219de55838b514187fffea9
Cr-Commit-Position: refs/heads/master@{#381281}

[sof, 2016-03-15 08:09:26]

sigbjornf@opera.com changed reviewers:
+ haraken@chromium.org

[sof, 2016-03-15 08:09:27]

please take a look.

a bit speculative, but the over-eager scheduling of in-order scripts is
potentially problem here.

[haraken, 2016-03-15 12:31:29]

LGTM

[sof, 2016-03-15 13:03:28]

Description was changed from

==========
Stop scheduling in-order script execution upon hitting failed script.

R=
BUG=581425
==========

to

==========
Stop scheduling in-order script execution upon hitting failed script.

R=haraken
BUG=581425
==========

[sof, 2016-03-15 13:03:37]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-03-15 13:03:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1798253002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1798253002/40001

[commit-bot: I haz the power, 2016-03-15 13:08:59]

Description was changed from

==========
Stop scheduling in-order script execution upon hitting failed script.

R=haraken
BUG=581425
==========

to

==========
Stop scheduling in-order script execution upon hitting failed script.

R=haraken
BUG=581425
==========

[commit-bot: I haz the power, 2016-03-15 13:09:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-15 13:10:03]

Description was changed from

==========
Stop scheduling in-order script execution upon hitting failed script.

R=haraken
BUG=581425
==========

to

==========
Stop scheduling in-order script execution upon hitting failed script.

R=haraken
BUG=581425

Committed: https://crrev.com/10cb02165d6d68a66007a3522f23a89fcb8a69d5
Cr-Commit-Position: refs/heads/master@{#381217}
==========

[commit-bot: I haz the power, 2016-03-15 13:10:03]

Patchset 3 (id:??) landed as
https://crrev.com/10cb02165d6d68a66007a3522f23a89fcb8a69d5
Cr-Commit-Position: refs/heads/master@{#381217}

[csharp, 2016-03-15 13:59:43]

On 2016/03/15 13:10:03, commit-bot: I haz the power wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/10cb02165d6d68a66007a3522f23a89fcb8a69d5
> Cr-Commit-Position: refs/heads/master@{#381217}

This change seems to have broken WebKit Win non-Oilpan (dbg).

Some output:
e:\b\build\slave\webkit_win_non-oilpan__dbg_\build\src\third_party\webkit\source\wtf\passrefptr.h(56):
error C2027: use of undefined type 'blink::ScriptStreamer'
e:\b\build\slave\webkit_win_non-oilpan__dbg_\build\src\third_party\webkit\source\core\dom\pendingscript.h(41):
note: see declaration of 'blink::ScriptStreamer'
e:\b\build\slave\webkit_win_non-oilpan__dbg_\build\src\third_party\webkit\source\wtf\refptr.h(59):
note: see reference to function template instantiation 'void
WTF::derefIfNotNull<T>(T *)' being compiled
        with
        [
            T=blink::ScriptStreamer
        ]
e:\b\build\slave\webkit_win_non-oilpan__dbg_\build\src\third_party\webkit\source\wtf\refptr.h(59):
note: while compiling class template member function
'WTF::RefPtr<blink::ScriptStreamer>::~RefPtr(void)'
e:\b\build\slave\webkit_win_non-oilpan__dbg_\build\src\third_party\webkit\source\core\dom\pendingscript.h(95):
note: see reference to function template instantiation
'WTF::RefPtr<blink::ScriptStreamer>::~RefPtr(void)' being compiled
e:\b\build\slave\webkit_win_non-oilpan__dbg_\build\src\third_party\webkit\source\core\dom\pendingscript.h(93):
note: see reference to class template instantiation
'WTF::RefPtr<blink::ScriptStreamer>' being compiled
e:\b\build\slave\webkit_win_non-oilpan__dbg_\build\src\third_party\webkit\source\wtf\passrefptr.h(56):
error C2227: left of '->deref' must point to class/struct/union/generic type
e:\b\build\slave\webkit_win_non-oilpan__dbg_\build\src\third_party\webkit\source\wtf\passrefptr.h(49):
error C2027: use of undefined type 'blink::ScriptStreamer'
e:\b\build\slave\webkit_win_non-oilpan__dbg_\build\src\third_party\webkit\source\core\dom\pendingscript.h(41):
note: see declaration of 'blink::ScriptStreamer'
e:\b\build\slave\webkit_win_non-oilpan__dbg_\build\src\third_party\webkit\source\wtf\refptr.h(46):
note: see reference to function template instantiation 'void
WTF::refIfNotNull<T>(T *)' being compiled
        with
        [
            T=blink::ScriptStreamer
        ]
e:\b\build\slave\webkit_win_non-oilpan__dbg_\build\src\third_party\webkit\source\wtf\refptr.h(46):
note: while compiling class template member function
'WTF::RefPtr<blink::ScriptStreamer>::RefPtr(const
WTF::RefPtr<blink::ScriptStreamer> &)'
e:\b\build\slave\webkit_win_non-oilpan__dbg_\build\src\third_party\webkit\source\core\dom\pendingscript.h(95):
note: see reference to function template instantiation
'WTF::RefPtr<blink::ScriptStreamer>::RefPtr(const
WTF::RefPtr<blink::ScriptStreamer> &)' being compiled
e:\b\build\slave\webkit_win_non-oilpan__dbg_\build\src\third_party\webkit\source\wtf\passrefptr.h(49):
error C2227: left of '->ref' must point to class/struct/union/generic type
FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc
"E:\b\depot_tools\win_toolchain\vs_files\391bbf1220d3edcd3cc3fccdb56224181e3b13a7\VC\bin\amd64_x86\cl.exe"
/nologo /showIncludes /FC
@obj\third_party\WebKit\Source\core\gen\blink\core\webcore_shared.HTMLElementFactory.obj.rsp
/c gen\blink\core\HTMLElementFactory.cpp
/Foobj\third_party\WebKit\Source\core\gen\blink\core\webcore_shared.HTMLElementFactory.obj
/Fdobj\third_party\WebKit\Source\core\webcore_shared.cc.pdb 
e:\b\build\slave\webkit_win_non-oilpan__dbg_\build\src\third_party\webkit\source\wtf\passrefptr.h(56):
error C2027: use of undefined type 'blink::ScriptStreamer'
e:\b\build\slave\webkit_win_non-oilpan__dbg_\build\src\third_party\webkit\source\core\dom\pendingscript.h(41):
note: see declaration of 'blink::ScriptStreamer'
e:\b\build\slave\webkit_win_non-oilpan__dbg_\build\src\third_party\webkit\source\wtf\refptr.h(59):
note: see reference to function template instantiation 'void
WTF::derefIfNotNull<T>(T *)' being compiled
        with
        [
            T=blink::ScriptStreamer
        ]

[csharp, 2016-03-15 14:00:23]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1801053002/ by csharp@chromium.org.

The reason for reverting is: This change seems to have broken the compile step
of the WebKit Win non-Oilpan bot..

[sof, 2016-03-15 14:25:46]

Description was changed from

==========
Stop scheduling in-order script execution upon hitting failed script.

R=haraken
BUG=581425

Committed: https://crrev.com/10cb02165d6d68a66007a3522f23a89fcb8a69d5
Cr-Commit-Position: refs/heads/master@{#381217}
==========

to

==========
Stop scheduling in-order script execution upon hitting failed script.

R=haraken
BUG=581425

Committed: https://crrev.com/10cb02165d6d68a66007a3522f23a89fcb8a69d5
Cr-Commit-Position: refs/heads/master@{#381217}
==========

[haraken, 2016-03-15 14:34:41]

LGTM assuming the bots are happy.

[sof, 2016-03-15 15:41:16]

On 2016/03/15 14:34:41, haraken wrote:
> LGTM assuming the bots are happy.

thanks, win non-Oilpan bots are now happy.

[sof, 2016-03-15 15:41:25]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-03-15 15:41:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1798253002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1798253002/60001

[commit-bot: I haz the power, 2016-03-15 18:02:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-15 18:02:18]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[sof, 2016-03-15 18:13:39]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-03-15 18:14:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1798253002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1798253002/60001

[commit-bot: I haz the power, 2016-03-15 19:32:31]

Description was changed from

==========
Stop scheduling in-order script execution upon hitting failed script.

R=haraken
BUG=581425

Committed: https://crrev.com/10cb02165d6d68a66007a3522f23a89fcb8a69d5
Cr-Commit-Position: refs/heads/master@{#381217}
==========

to

==========
Stop scheduling in-order script execution upon hitting failed script.

R=haraken
BUG=581425

Committed: https://crrev.com/10cb02165d6d68a66007a3522f23a89fcb8a69d5
Cr-Commit-Position: refs/heads/master@{#381217}
==========

[commit-bot: I haz the power, 2016-03-15 19:32:32]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-15 19:33:58]

Description was changed from

==========
Stop scheduling in-order script execution upon hitting failed script.

R=haraken
BUG=581425

Committed: https://crrev.com/10cb02165d6d68a66007a3522f23a89fcb8a69d5
Cr-Commit-Position: refs/heads/master@{#381217}
==========

to

==========
Stop scheduling in-order script execution upon hitting failed script.

R=haraken
BUG=581425

Committed: https://crrev.com/10cb02165d6d68a66007a3522f23a89fcb8a69d5
Cr-Commit-Position: refs/heads/master@{#381217}

Committed: https://crrev.com/fde6c7118d13dbe3e219de55838b514187fffea9
Cr-Commit-Position: refs/heads/master@{#381281}
==========

[commit-bot: I haz the power, 2016-03-15 19:33:59]

Patchset 4 (id:??) landed as
https://crrev.com/fde6c7118d13dbe3e219de55838b514187fffea9
Cr-Commit-Position: refs/heads/master@{#381281}