Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: src/liveedit.cc

Issue 179813005: Special case the recording of constant pool entries in the slot buffer. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/liveedit.cc
diff --git a/src/liveedit.cc b/src/liveedit.cc
index 002e0624367977eb9b5623cdacf7e7d9f8fc0100..c98123299cbeb14dec34e04dc39c546a18acc003 100644
--- a/src/liveedit.cc
+++ b/src/liveedit.cc
@@ -1021,6 +1021,14 @@ class ReplacingVisitor : public ObjectVisitor {
}
}
+ virtual void VisitCodeTarget(Address target_address_pointer) {
+ if (Code::GetCodeFromTargetAddress(
+ Memory::Address_at(target_address_pointer)) == original_) {
+ Address substitution_entry = substitution_->instruction_start();
+ *reinterpret_cast<Address*>(target_address_pointer) = substitution_entry;
Michael Starzinger 2014/03/07 14:36:59 Can we instead of the reinterpret cast use ... Me
rmcilroy 2014/03/10 12:25:23 Removed VisitCodeTarget(Address) as discussed, so
+ }
+ }
+
virtual void VisitCodeTarget(RelocInfo* rinfo) {
if (RelocInfo::IsCodeTarget(rinfo->rmode()) &&
Code::GetCodeFromTargetAddress(rinfo->target_address()) == original_) {

Powered by Google App Engine
This is Rietveld 408576698