Special case the recording of constant pool entries in the slot buffer.

src/liveedit.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1003 matching lines @@
     }
   }
 
   virtual void VisitCodeEntry(Address entry) {
     if (Code::GetObjectFromEntryAddress(entry) == original_) {
       Address substitution_entry = substitution_->instruction_start();
       Memory::Address_at(entry) = substitution_entry;
     }
   }
 
+  virtual void VisitCodeTarget(Address target_address_pointer) {
+    if (Code::GetCodeFromTargetAddress(
+            Memory::Address_at(target_address_pointer)) == original_) {
+      Address substitution_entry = substitution_->instruction_start();
+      *reinterpret_cast<Address*>(target_address_pointer) = substitution_entry;

[Michael Starzinger, 2014/03/07 14:36:59]

Can we instead of the reinterpret cast use ...

Memory::Address_at(target_address_pointer) = substitution_entry;

[rmcilroy, 2014/03/10 12:25:23]

Removed VisitCodeTarget(Address) as discussed, so no longer applicable.

+    }
+  }
+
   virtual void VisitCodeTarget(RelocInfo* rinfo) {
     if (RelocInfo::IsCodeTarget(rinfo->rmode()) &&
         Code::GetCodeFromTargetAddress(rinfo->target_address()) == original_) {
       Address substitution_entry = substitution_->instruction_start();
       rinfo->set_target_address(substitution_entry);
     }
   }
 
   virtual void VisitDebugTarget(RelocInfo* rinfo) {
     VisitCodeTarget(rinfo);
@@ skipping 1097 matching lines @@
 
 bool LiveEditFunctionTracker::IsActive(Isolate* isolate) {
   return false;
 }
 
 #endif  // ENABLE_DEBUGGER_SUPPORT
 
 
 
 } }  // namespace v8::internal