Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: tests/lib/mirrors/globalized_closures2_test.dart

Issue 179803004: Assign invalid name to globalized closures. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove debug-print and add tests. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/lib.status ('k') | tests/lib/mirrors/globalized_closures_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/mirrors/globalized_closures2_test.dart
diff --git a/tests/lib/mirrors/globalized_closures2_test.dart b/tests/lib/mirrors/globalized_closures2_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..36c211a06de419a7b94f46be0420af1d30c87ca2
--- /dev/null
+++ b/tests/lib/mirrors/globalized_closures2_test.dart
@@ -0,0 +1,37 @@
+// Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+// Dart2js crashed on this example. It globalized both closures and created
+// top-level classes for closures (here the globalized_closure{2}). There was a
+// name-clash (both being named "main_closure") which led to a crash.
+
+library main;
+
+import 'dart:mirrors';
+
+import 'package:expect/expect.dart';
+
+confuse(x) {
+ if (new DateTime.now().millisecondsSinceEpoch == 42) {
+ return confuse(() => print(42));
+ }
+ return x;
+}
+
+main() {
+ var globalized_closure = confuse(() => 499);
+ var globalized_closure2 = confuse(() => 99);
+ globalized_closure();
+ globalized_closure2();
+ final ms = currentMirrorSystem();
+ var lib = ms.findLibrary(#main);
+ var collectedParents = [];
+ var classes = lib.declarations.values;
+ for (var c in classes) {
+ if (c is ClassMirror && c.superclass != null) {
+ collectedParents.add(MirrorSystem.getName(c.superclass.simpleName));
+ }
+ };
+ Expect.isTrue(collectedParents.isEmpty); /// 00: ok
+}
« no previous file with comments | « tests/lib/lib.status ('k') | tests/lib/mirrors/globalized_closures_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698