Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1797793003: Fix AddressField "lookup" fields ignore logic. (Closed)

Created:
4 years, 9 months ago by sense (YandexTeam)
Modified:
4 years, 9 months ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix AddressField "lookup" fields ignore logic. In http://crbug.com/427622 were added ignore of "lookup"-named address fields. This ignore moves scanner forward, and if ignored field is the last in the form, then next Parse* calls inside of AddressField::Parse is invalid. This fix moves ignore logic to the beginning of AddressField::Parse. R=estade@chromium.org BUG=594475 Committed: https://crrev.com/a6c3faf29e00ffff8f31b97a09e77294f1b4eaae Cr-Commit-Position: refs/heads/master@{#380956}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
A chrome/test/data/autofill/heuristics/input/139_bug_594475.html View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/test/data/autofill/heuristics/output/139_bug_594475.out View 1 chunk +3 lines, -0 lines 0 comments Download
M components/autofill/core/browser/address_field.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sense (YandexTeam)
4 years, 9 months ago (2016-03-14 10:13:58 UTC) #1
vabr (Chromium)
lgtm
4 years, 9 months ago (2016-03-14 10:35:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1797793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1797793003/1
4 years, 9 months ago (2016-03-14 11:09:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-14 12:26:35 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 12:29:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6c3faf29e00ffff8f31b97a09e77294f1b4eaae
Cr-Commit-Position: refs/heads/master@{#380956}

Powered by Google App Engine
This is Rietveld 408576698