Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Unified Diff: components/autofill/core/browser/address_field.cc

Issue 1797793003: Fix AddressField "lookup" fields ignore logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/autofill/heuristics/output/139_bug_594475.out ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/address_field.cc
diff --git a/components/autofill/core/browser/address_field.cc b/components/autofill/core/browser/address_field.cc
index 7fbc2cfa87111ce413d5734471c08b9ea0231e69..de54d6bd8202e1dbbf17b7fd8f594007520ce0c5 100644
--- a/components/autofill/core/browser/address_field.cc
+++ b/components/autofill/core/browser/address_field.cc
@@ -57,7 +57,10 @@ scoped_ptr<FormField> AddressField::Parse(AutofillScanner* scanner) {
bool has_trailing_non_labeled_fields = false;
while (!scanner->IsEnd()) {
const size_t cursor = scanner->SaveCursor();
- if (address_field->ParseAddressLines(scanner) ||
+ // Ignore "Address Lookup" field. http://crbug.com/427622
+ if (ParseField(scanner, base::UTF8ToUTF16(kAddressLookupRe), NULL)) {
+ continue;
+ } else if (address_field->ParseAddressLines(scanner) ||
address_field->ParseCityStateZipCode(scanner) ||
address_field->ParseCountry(scanner) ||
address_field->ParseCompany(scanner)) {
@@ -174,10 +177,6 @@ bool AddressField::ParseAddressLines(AutofillScanner* scanner) {
if (address1_ || street_address_)
return false;
- // Ignore "Address Lookup" field. http://crbug.com/427622
- if (ParseField(scanner, base::UTF8ToUTF16(kAddressLookupRe), NULL))
- return false;
-
base::string16 pattern = UTF8ToUTF16(kAddressLine1Re);
base::string16 label_pattern = UTF8ToUTF16(kAddressLine1LabelRe);
if (!ParseFieldSpecifics(scanner, pattern, MATCH_DEFAULT, &address1_) &&
« no previous file with comments | « chrome/test/data/autofill/heuristics/output/139_bug_594475.out ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698